You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Grzegorz Kossakowski (aka g[R]eK) (JIRA)" <ji...@apache.org> on 2007/01/28 18:40:49 UTC
[jira] Created: (COCOON-1993) Make Forms resources loaded directly
Make Forms resources loaded directly
------------------------------------
Key: COCOON-1993
URL: https://issues.apache.org/jira/browse/COCOON-1993
Project: Cocoon
Issue Type: Sub-task
Components: Blocks: Forms
Affects Versions: 2.2-dev (Current SVN)
Reporter: Grzegorz Kossakowski (aka g[R]eK)
Fix For: 2.2-dev (Current SVN)
Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (COCOON-1993) Make Forms resources loaded directly
Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grzegorz Kossakowski reassigned COCOON-1993:
--------------------------------------------
Assignee: Grzegorz Kossakowski
> Make Forms resources loaded directly
> ------------------------------------
>
> Key: COCOON-1993
> URL: https://issues.apache.org/jira/browse/COCOON-1993
> Project: Cocoon
> Issue Type: Sub-task
> Components: Blocks: Forms
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski
> Assigned To: Grzegorz Kossakowski
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: cocoon-forms-impl-patch-1.txt, cocoon-forms-impl-patch-2.txt, cocoon-forms-impl-patch-3.txt, cocoon-forms-impl-patch-4.txt, cocoon-forms-sample-patch-1.txt, cocoon-forms-sample-patch-2.txt, cocoon-forms-sample-patch-3.txt
>
>
> Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-1993) Make Forms resources loaded directly
Posted by "Grzegorz Kossakowski (aka g[R]eK) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grzegorz Kossakowski (aka g[R]eK) updated COCOON-1993:
------------------------------------------------------
Attachment: cocoon-forms-sample-patch-1.txt
> Make Forms resources loaded directly
> ------------------------------------
>
> Key: COCOON-1993
> URL: https://issues.apache.org/jira/browse/COCOON-1993
> Project: Cocoon
> Issue Type: Sub-task
> Components: Blocks: Forms
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski (aka g[R]eK)
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: cocoon-forms-impl-patch-1.txt, cocoon-forms-sample-patch-1.txt
>
>
> Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-1993) Make Forms resources loaded directly
Posted by "Reinhard Poetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reinhard Poetz updated COCOON-1993:
-----------------------------------
Other Info: [Patch available]
> Make Forms resources loaded directly
> ------------------------------------
>
> Key: COCOON-1993
> URL: https://issues.apache.org/jira/browse/COCOON-1993
> Project: Cocoon
> Issue Type: Sub-task
> Components: Blocks: Forms
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski (aka g[R]eK)
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: cocoon-forms-impl-patch-1.txt, cocoon-forms-impl-patch-2.txt, cocoon-forms-sample-patch-1.txt, cocoon-forms-sample-patch-2.txt
>
>
> Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-1993) Make Forms resources loaded directly
Posted by "Grzegorz Kossakowski (aka g[R]eK) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grzegorz Kossakowski (aka g[R]eK) updated COCOON-1993:
------------------------------------------------------
Attachment: cocoon-forms-impl-patch-3.txt
cocoon-forms-impl-patch-3.txt:
Patch adapted to the latest changes of servlet-service-fw, see http://article.gmane.org/gmane.text.xml.cocoon.cvs/23271 for details.
This patch also makes use of servletLinkRewriterReader introduced in COCOON-1997. This way, refactoring of resources locations seems to be complete. This applies to the resources exposed to browser (html code, js, etc).
I'm thinking of refactoring links in server-side resources (xsl, js for flowscript) but it's not priority-critical.
> Make Forms resources loaded directly
> ------------------------------------
>
> Key: COCOON-1993
> URL: https://issues.apache.org/jira/browse/COCOON-1993
> Project: Cocoon
> Issue Type: Sub-task
> Components: Blocks: Forms
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski (aka g[R]eK)
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: cocoon-forms-impl-patch-1.txt, cocoon-forms-impl-patch-2.txt, cocoon-forms-impl-patch-3.txt, cocoon-forms-sample-patch-1.txt, cocoon-forms-sample-patch-2.txt
>
>
> Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-1993) Make Forms resources loaded directly
Posted by "Grzegorz Kossakowski (aka g[R]eK) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grzegorz Kossakowski (aka g[R]eK) updated COCOON-1993:
------------------------------------------------------
Attachment: cocoon-forms-impl-patch-2.txt
cocoon-forms-impl-patch-2.txt:
This patch fixes issues related to paths problems mentioned before. Actually, I've split paths in js and xslt files so resources form different blocks can be mounted on completely different locations.
Also I've moved manifest.js to the right location and added it required by calling dojo.required so Dojo doesn't have to guess location of this file. Adding cocoon.forms.manifest to required assures that it's loaded on right phase and our namescape handler is registered before it's being used.
Splitting paths demanded changes in various places, but I think that led to cleaner contracts. There is no resourecesUri variable that would be used to load resources from different blocks, and thus making any further refactorings much harder.
This patch includes all changes from previous one.
WARNING: Some paths (see manifest.js) are hardcoded until I write link rewriting reader discussed here: http://article.gmane.org/gmane.text.xml.cocoon.devel/70027
> Make Forms resources loaded directly
> ------------------------------------
>
> Key: COCOON-1993
> URL: https://issues.apache.org/jira/browse/COCOON-1993
> Project: Cocoon
> Issue Type: Sub-task
> Components: Blocks: Forms
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski (aka g[R]eK)
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: cocoon-forms-impl-patch-1.txt, cocoon-forms-impl-patch-2.txt, cocoon-forms-sample-patch-1.txt
>
>
> Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-1993) Make Forms resources loaded directly
Posted by "Grzegorz Kossakowski (aka g[R]eK) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grzegorz Kossakowski (aka g[R]eK) updated COCOON-1993:
------------------------------------------------------
Attachment: cocoon-forms-impl-patch-1.txt
> Make Forms resources loaded directly
> ------------------------------------
>
> Key: COCOON-1993
> URL: https://issues.apache.org/jira/browse/COCOON-1993
> Project: Cocoon
> Issue Type: Sub-task
> Components: Blocks: Forms
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski (aka g[R]eK)
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: cocoon-forms-impl-patch-1.txt
>
>
> Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-1993) Make Forms resources loaded
directly
Posted by "Daniel Fagerstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474039 ]
Daniel Fagerstrom commented on COCOON-1993:
-------------------------------------------
The new content and location of manifest.js seem to be lacking in the patch. Now it is only removed.
> Make Forms resources loaded directly
> ------------------------------------
>
> Key: COCOON-1993
> URL: https://issues.apache.org/jira/browse/COCOON-1993
> Project: Cocoon
> Issue Type: Sub-task
> Components: Blocks: Forms
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski (aka g[R]eK)
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: cocoon-forms-impl-patch-1.txt, cocoon-forms-impl-patch-2.txt, cocoon-forms-impl-patch-3.txt, cocoon-forms-sample-patch-1.txt, cocoon-forms-sample-patch-2.txt, cocoon-forms-sample-patch-3.txt
>
>
> Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-1993) Make Forms resources loaded directly
Posted by "Grzegorz Kossakowski (aka g[R]eK) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grzegorz Kossakowski (aka g[R]eK) updated COCOON-1993:
------------------------------------------------------
Attachment: cocoon-forms-sample-patch-2.txt
cocoon-forms-sample-patch-2.txt:
All resource-uri parameters has been replaced by dojo-resources and forms-resources parameters. For details take a look at comments on cocoon-forms-impl-patch-2.txt.
I've also changed bean definition of SitemapServlet to use servlet-service-fw instead of blocks-fw.
This patch affects cocoon-forms-sample module only and includes all changes from previous patch.
> Make Forms resources loaded directly
> ------------------------------------
>
> Key: COCOON-1993
> URL: https://issues.apache.org/jira/browse/COCOON-1993
> Project: Cocoon
> Issue Type: Sub-task
> Components: Blocks: Forms
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski (aka g[R]eK)
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: cocoon-forms-impl-patch-1.txt, cocoon-forms-impl-patch-2.txt, cocoon-forms-sample-patch-1.txt, cocoon-forms-sample-patch-2.txt
>
>
> Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COCOON-1993) Make Forms resources loaded directly
Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grzegorz Kossakowski closed COCOON-1993.
----------------------------------------
Resolution: Fixed
All resources are loaded directly so the task is accomplished.
> Make Forms resources loaded directly
> ------------------------------------
>
> Key: COCOON-1993
> URL: https://issues.apache.org/jira/browse/COCOON-1993
> Project: Cocoon
> Issue Type: Sub-task
> Components: Blocks: Forms
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski
> Assigned To: Grzegorz Kossakowski
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: cocoon-forms-impl-patch-1.txt, cocoon-forms-impl-patch-2.txt, cocoon-forms-impl-patch-3.txt, cocoon-forms-impl-patch-4.txt, cocoon-forms-sample-patch-1.txt, cocoon-forms-sample-patch-2.txt, cocoon-forms-sample-patch-3.txt
>
>
> Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-1993) Make Forms resources loaded
directly
Posted by "Daniel Fagerstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474282 ]
Daniel Fagerstrom commented on COCOON-1993:
-------------------------------------------
The samples works for me. But as said above we cannot apply it until it either works with 2.1 (which seem complicated) or until we have stoped sharing the 2.1 and 2.2 code.
> Make Forms resources loaded directly
> ------------------------------------
>
> Key: COCOON-1993
> URL: https://issues.apache.org/jira/browse/COCOON-1993
> Project: Cocoon
> Issue Type: Sub-task
> Components: Blocks: Forms
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: cocoon-forms-impl-patch-1.txt, cocoon-forms-impl-patch-2.txt, cocoon-forms-impl-patch-3.txt, cocoon-forms-impl-patch-4.txt, cocoon-forms-sample-patch-1.txt, cocoon-forms-sample-patch-2.txt, cocoon-forms-sample-patch-3.txt
>
>
> Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-1993) Make Forms resources loaded
directly
Posted by "Reinhard Poetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469780 ]
Reinhard Poetz commented on COCOON-1993:
----------------------------------------
@the person who plans to applay this patch: This patch will break the samples in 2.1 as the samples code is shared. Please bring up this issue at dev@cocoon for further discussion. Thanks!
> Make Forms resources loaded directly
> ------------------------------------
>
> Key: COCOON-1993
> URL: https://issues.apache.org/jira/browse/COCOON-1993
> Project: Cocoon
> Issue Type: Sub-task
> Components: Blocks: Forms
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski (aka g[R]eK)
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: cocoon-forms-impl-patch-1.txt, cocoon-forms-impl-patch-2.txt, cocoon-forms-sample-patch-1.txt, cocoon-forms-sample-patch-2.txt
>
>
> Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-1993) Make Forms resources loaded directly
Posted by "Grzegorz Kossakowski (aka g[R]eK) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grzegorz Kossakowski (aka g[R]eK) updated COCOON-1993:
------------------------------------------------------
Attachment: cocoon-forms-sample-patch-3.txt
cocoon-forms-sample-patch-3.txt:
Patch adapted to the latest changes of servlet-service-fw, see http://article.gmane.org/gmane.text.xml.cocoon.cvs/23271 for details.
> Make Forms resources loaded directly
> ------------------------------------
>
> Key: COCOON-1993
> URL: https://issues.apache.org/jira/browse/COCOON-1993
> Project: Cocoon
> Issue Type: Sub-task
> Components: Blocks: Forms
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski (aka g[R]eK)
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: cocoon-forms-impl-patch-1.txt, cocoon-forms-impl-patch-2.txt, cocoon-forms-impl-patch-3.txt, cocoon-forms-sample-patch-1.txt, cocoon-forms-sample-patch-2.txt, cocoon-forms-sample-patch-3.txt
>
>
> Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-1993) Make Forms resources loaded directly
Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grzegorz Kossakowski updated COCOON-1993:
-----------------------------------------
Attachment: cocoon-forms-impl-patch-4.txt
cocoon-forms-impl-patch-4.txt:
Grrr. Another bug in Subclipse found. When you move file and make additional modifications, only those modifications will be included in the patch. That makes applying patch broken.
Now it should work.
> Make Forms resources loaded directly
> ------------------------------------
>
> Key: COCOON-1993
> URL: https://issues.apache.org/jira/browse/COCOON-1993
> Project: Cocoon
> Issue Type: Sub-task
> Components: Blocks: Forms
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: cocoon-forms-impl-patch-1.txt, cocoon-forms-impl-patch-2.txt, cocoon-forms-impl-patch-3.txt, cocoon-forms-impl-patch-4.txt, cocoon-forms-sample-patch-1.txt, cocoon-forms-sample-patch-2.txt, cocoon-forms-sample-patch-3.txt
>
>
> Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-1993) Make Forms resources loaded
directly
Posted by "Grzegorz Kossakowski (aka g[R]eK) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468137 ]
Grzegorz Kossakowski (aka g[R]eK) commented on COCOON-1993:
-----------------------------------------------------------
Steps required to test them are the same as in https://issues.apache.org/jira/browse/COCOON-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468136
Unfortunately this is not working now. If point your browser to http://localhost:8888/blocks-test/cocoon-forms-sample/form1.flow you'll see that some resources are not properly loaded. This happens because some paths are messed up. For example it tries to load:
http://localhost:8888/blocks-test/cocoon-ajax-impl/resources/forms/manifest.js
http://localhost:8888/blocks-test/cocoon-ajax-impl/resources/forms.js
But of course forms.js is not on location mentioned above. I have no idea where these paths come from but fortunately Jeremy Quinn offered his help.
> Make Forms resources loaded directly
> ------------------------------------
>
> Key: COCOON-1993
> URL: https://issues.apache.org/jira/browse/COCOON-1993
> Project: Cocoon
> Issue Type: Sub-task
> Components: Blocks: Forms
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski (aka g[R]eK)
> Fix For: 2.2-dev (Current SVN)
>
> Attachments: cocoon-forms-impl-patch-1.txt, cocoon-forms-sample-patch-1.txt
>
>
> Steps required to achieve this goal are the same as in https://issues.apache.org/jira/browse/COCOON-1992
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.