You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2015/12/17 03:38:51 UTC

Re: Review Request 41407: Unified Container: Save all docker image information on disk instead of rootfs only.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41407/
-----------------------------------------------------------

(Updated Dec. 16, 2015, 6:38 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-2980
    https://issues.apache.org/jira/browse/MESOS-2980


Repository: mesos


Description
-------

Unified Container: Save all docker image information on disk instead of rootfs only.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 4aa4a9c4074d96c30c3bceea59d071feeecae2ea 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
  src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2 

Diff: https://reviews.apache.org/r/41407/diff/


Testing
-------

make check


Thanks,

Gilbert Song


Re: Review Request 41407: Unified Container: Save all docker image information on disk instead of rootfs only.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41407/#review110908
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Dec. 17, 2015, 2:38 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41407/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 2:38 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2980
>     https://issues.apache.org/jira/browse/MESOS-2980
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unified Container: Save all docker image information on disk instead of rootfs only.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 4aa4a9c4074d96c30c3bceea59d071feeecae2ea 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
>   src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2 
> 
> Diff: https://reviews.apache.org/r/41407/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Re: Review Request 41407: Unified Container: Save all docker image information on disk instead of rootfs only.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41407/
-----------------------------------------------------------

(Updated Dec. 18, 2015, 1:31 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-2980
    https://issues.apache.org/jira/browse/MESOS-2980


Repository: mesos


Description
-------

Unified Container: Save all docker image information on disk instead of rootfs only.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 7e830bc00b1533092735063b4b93039058806111 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
  src/tests/containerizer/provisioner_docker_tests.cpp b57ee8681e0861cf93f5dcf9368c004a57df1374 

Diff: https://reviews.apache.org/r/41407/diff/


Testing
-------

make check


Thanks,

Gilbert Song


Re: Review Request 41407: Unified Container: Save all docker image information on disk instead of rootfs only.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41407/
-----------------------------------------------------------

(Updated Dec. 17, 2015, 1:16 a.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-2980
    https://issues.apache.org/jira/browse/MESOS-2980


Repository: mesos


Description
-------

Unified Container: Save all docker image information on disk instead of rootfs only.


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 4aa4a9c4074d96c30c3bceea59d071feeecae2ea 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 1ad7b67a94b1d9367afcb7c30a6d01fdf6b8ab6c 
  src/tests/containerizer/provisioner_docker_tests.cpp 3f1717b770e139c3759aab0aeda9dbcf5029b0c2 

Diff: https://reviews.apache.org/r/41407/diff/


Testing
-------

make check


Thanks,

Gilbert Song