You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/23 16:59:51 UTC

[GitHub] [tvm] tkonolige commented on a change in pull request #10724: [ARM] Support NCHWc alter layout in the fallback mode

tkonolige commented on a change in pull request #10724:
URL: https://github.com/apache/tvm/pull/10724#discussion_r833501478



##########
File path: python/tvm/topi/arm_cpu/conv2d_alter_op.py
##########
@@ -357,6 +355,7 @@ def _alter_conv2d_layout(attrs, inputs, tinfos, out_type):
                 out_dtype,
                 False,
                 data_layout,
+                int32_lanes=32,

Review comment:
       I think this should be `4` to match https://github.com/apache/tvm/blob/main/python/tvm/topi/arm_cpu/conv2d_int8.py#L175-L181.

##########
File path: python/tvm/topi/x86/conv2d_int8.py
##########
@@ -34,7 +34,16 @@
 
 
 def _get_default_config_int8(
-    cfg, data, kernel, strides, padding, dilation, out_dtype, is_depthwise=False, layout="NCHW"
+    cfg,
+    data,
+    kernel,
+    strides,
+    padding,
+    dilation,
+    out_dtype,
+    is_depthwise=False,
+    layout="NCHW",
+    int32_lanes=16,

Review comment:
       Also should be 4 by default.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org