[GitHub] [hadoop] functioner commented on a change in pull request #2737: HDFS-15869. Network issue while FSEditLogAsync is executing RpcEdit.logSyncNotify can cause the namenode to hang

[GitBox <gi...@apache.org>]

functioner commented on a change in pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#discussion_r601739047



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java
##########
@@ -63,6 +68,9 @@
             DFS_NAMENODE_EDITS_ASYNC_LOGGING_PENDING_QUEUE_SIZE_DEFAULT);
 
     editPendingQ = new ArrayBlockingQueue<>(editPendingQSize);
+
+    // the thread pool size should be configurable later, and justified with a rationale
+    logSyncNotifyExecutor = Executors.newFixedThreadPool(10);

Review comment:
       Sure. What should be the default value? Many users use the default value, so probably we shouldn't set it as 0 by default.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org