[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #5056: [TE] [data-availability] Scheduling of data availability tasks & some clean up

[GitBox <gi...@apache.org>]

akshayrai commented on a change in pull request #5056: [TE] [data-availability] Scheduling of data availability tasks & some clean up
URL: https://github.com/apache/incubator-pinot/pull/5056#discussion_r377941871
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/ThirdEyeAnomalyApplication.java
 ##########
 @@ -41,8 +41,8 @@
 import org.apache.pinot.thirdeye.datasource.DAORegistry;
 import org.apache.pinot.thirdeye.datasource.ThirdEyeCacheRegistry;
 import org.apache.pinot.thirdeye.datasource.pinot.resources.PinotDataSourceResource;
-import org.apache.pinot.thirdeye.detection.DetectionPipelineScheduler;
-import org.apache.pinot.thirdeye.detection.alert.DetectionAlertScheduler;
+import org.apache.pinot.thirdeye.scheduler.DetectionScheduler;
+import org.apache.pinot.thirdeye.scheduler.SubscriptionScheduler;
 
 Review comment:
   @xiaohui-sun, yes, I have been consistently trying to enforce the usage of subscription rather than detection_alert in our code (this pr and in the past). detection_alert is a very confusing term.
   
   The database still holds the references as detection_alert which is a little harder to migrate but eventually we should.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org