[GitHub] [pulsar] nyluke commented on a change in pull request #4676: Enable a self-contained build of the pulsar-cpp-client static library

[GitBox <gi...@apache.org>]

nyluke commented on a change in pull request #4676: Enable a self-contained build of the pulsar-cpp-client static library
URL: https://github.com/apache/pulsar/pull/4676#discussion_r301173244
 
 

 ##########
 File path: pulsar-client-cpp/lib/CMakeLists.txt
 ##########
 @@ -113,5 +120,10 @@ else()
     install(TARGETS pulsarStatic DESTINATION lib)
 endif(LINK_STATIC)
 
-install(TARGETS pulsarShared pulsarStatic DESTINATION lib)
+if (BUILD_SHARED)
+    install(TARGETS pulsarShared pulsarStatic DESTINATION lib)
+else()
+    install(TARGETS pulsarStatic DESTINATION lib)
 
 Review comment:
   My goal was to enable a "self-contained" build, meaning zero dependencies on the currently installed system libraries, without going through whole Docker -> RPM process. My current build procedure builds all static libs for all of my external dependencies from their latest sources and links my executable to them. The shared library cannot be built in this environment since it depends on the other shared libs being present, or at least that the static libs be built with PIC which I'd rather not use. Enabling a "static-only" build resolves this issue for me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services