You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/17 07:01:26 UTC

[GitHub] [arrow-rs] nl5887 commented on pull request #1891: Feature add weekday temporal kernel

nl5887 commented on PR #1891:
URL: https://github.com/apache/arrow-rs/pull/1891#issuecomment-1158559358

   > Looks like at least one test need to be updated:
   > 
   > https://github.com/apache/arrow-rs/runs/6924858466?check_suite_focus=true
   > 
   > ![Screen Shot 2022-06-16 at 4 11 00 PM](https://user-images.githubusercontent.com/490673/174155775-c9d8c2fb-7ba9-4625-bf35-c97189dd8e57.png)
   
   Thanks, updated the test. Any opinions if we should use the ISO 8601 (similar to chrono-rs) week days (starting at Monday) or the US (starting at Sunday)? Currently it is using ISO (https://docs.rs/chrono/latest/src/chrono/lib.rs.html#646).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org