You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/09 12:47:48 UTC

[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15974: fix: LookupRequestSemaphore don't release when success

Technoboy- commented on code in PR #15974:
URL: https://github.com/apache/pulsar/pull/15974#discussion_r893459665


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/lookup/TopicLookupBase.java:
##########
@@ -337,6 +338,11 @@ protected void completeLookupResponseExceptionally(AsyncResponse asyncResponse,
         asyncResponse.resume(cause);
     }
 
+    protected void completeLookupResponseSuccessfully(AsyncResponse asyncResponse, LookupData lookupData) {

Review Comment:
   Why add this method ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org