You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/09/29 03:03:32 UTC

[GitHub] [hudi] tangyoupeng opened a new pull request #3729: Support JuiceFileSystem

tangyoupeng opened a new pull request #3729:
URL: https://github.com/apache/hudi/pull/3729


   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   Support JuiceFileSystem
   https://github.com/juicedata/juicefs
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3729: Support JuiceFileSystem

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3729:
URL: https://github.com/apache/hudi/pull/3729#issuecomment-929788240






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] tangyoupeng commented on a change in pull request #3729: Support JuiceFileSystem

Posted by GitBox <gi...@apache.org>.
tangyoupeng commented on a change in pull request #3729:
URL: https://github.com/apache/hudi/pull/3729#discussion_r719021678



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/fs/StorageSchemes.java
##########
@@ -62,6 +62,8 @@
   OBS("obs", false),
   // Kingsoft Standard Storage ks3
   KS3("ks3", false),
+  // JuiceFileSystem
+  JFS("jfs", true),

Review comment:
       #3736 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] tangyoupeng commented on a change in pull request #3729: Support JuiceFileSystem

Posted by GitBox <gi...@apache.org>.
tangyoupeng commented on a change in pull request #3729:
URL: https://github.com/apache/hudi/pull/3729#discussion_r718202955



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/fs/StorageSchemes.java
##########
@@ -62,6 +62,8 @@
   OBS("obs", false),
   // Kingsoft Standard Storage ks3
   KS3("ks3", false),
+  // JuiceFileSystem
+  JFS("jfs", true),

Review comment:
       ok, i will do it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] leesf commented on a change in pull request #3729: Support JuiceFileSystem

Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3729:
URL: https://github.com/apache/hudi/pull/3729#discussion_r718152109



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/fs/StorageSchemes.java
##########
@@ -62,6 +62,8 @@
   OBS("obs", false),
   // Kingsoft Standard Storage ks3
   KS3("ks3", false),
+  // JuiceFileSystem
+  JFS("jfs", true),

Review comment:
       can we also add some docs on how to use jfs like this http://hudi.apache.org/docs/cloud in another PR(on asf-site branch rather than master branch)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] xiaogaozi commented on pull request #3729: Support JuiceFileSystem

Posted by GitBox <gi...@apache.org>.
xiaogaozi commented on pull request #3729:
URL: https://github.com/apache/hudi/pull/3729#issuecomment-939831312


   @leesf https://issues.apache.org/jira/browse/HUDI-1139 Maybe link this pull request with this JIRA issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3729: Support JuiceFileSystem

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3729:
URL: https://github.com/apache/hudi/pull/3729#issuecomment-929788240


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c66e724bfa44a5147aaaac8965bb585d07ac3b36",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2455",
       "triggerID" : "c66e724bfa44a5147aaaac8965bb585d07ac3b36",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c66e724bfa44a5147aaaac8965bb585d07ac3b36 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2455) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3729: Support JuiceFileSystem

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3729:
URL: https://github.com/apache/hudi/pull/3729#issuecomment-929788240


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c66e724bfa44a5147aaaac8965bb585d07ac3b36",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c66e724bfa44a5147aaaac8965bb585d07ac3b36",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c66e724bfa44a5147aaaac8965bb585d07ac3b36 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #3729: Support JuiceFileSystem

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3729:
URL: https://github.com/apache/hudi/pull/3729#issuecomment-929788240


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c66e724bfa44a5147aaaac8965bb585d07ac3b36",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c66e724bfa44a5147aaaac8965bb585d07ac3b36",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c66e724bfa44a5147aaaac8965bb585d07ac3b36 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot edited a comment on pull request #3729: Support JuiceFileSystem

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3729:
URL: https://github.com/apache/hudi/pull/3729#issuecomment-929788240


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c66e724bfa44a5147aaaac8965bb585d07ac3b36",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2455",
       "triggerID" : "c66e724bfa44a5147aaaac8965bb585d07ac3b36",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c66e724bfa44a5147aaaac8965bb585d07ac3b36 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2455) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] leesf merged pull request #3729: Support JuiceFileSystem

Posted by GitBox <gi...@apache.org>.
leesf merged pull request #3729:
URL: https://github.com/apache/hudi/pull/3729


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] tangyoupeng commented on a change in pull request #3729: Support JuiceFileSystem

Posted by GitBox <gi...@apache.org>.
tangyoupeng commented on a change in pull request #3729:
URL: https://github.com/apache/hudi/pull/3729#discussion_r718202955



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/fs/StorageSchemes.java
##########
@@ -62,6 +62,8 @@
   OBS("obs", false),
   // Kingsoft Standard Storage ks3
   KS3("ks3", false),
+  // JuiceFileSystem
+  JFS("jfs", true),

Review comment:
       ok, i will do it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] leesf commented on a change in pull request #3729: Support JuiceFileSystem

Posted by GitBox <gi...@apache.org>.
leesf commented on a change in pull request #3729:
URL: https://github.com/apache/hudi/pull/3729#discussion_r718152109



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/fs/StorageSchemes.java
##########
@@ -62,6 +62,8 @@
   OBS("obs", false),
   // Kingsoft Standard Storage ks3
   KS3("ks3", false),
+  // JuiceFileSystem
+  JFS("jfs", true),

Review comment:
       can we also add some docs on how to use jfs like this http://hudi.apache.org/docs/cloud in another PR(on asf-site branch rather than master branch)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org