You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/07/09 19:47:27 UTC
[GitHub] [geode] nabarunnag opened a new pull request #6690: Revert "GEODE-9139 SSLException in starting up a Locator (#6308)(#6401)"
nabarunnag opened a new pull request #6690:
URL: https://github.com/apache/geode/pull/6690
This reverts commit 863835969db3b5408764887aeeaf3b6943040c68.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #6690: Revert "GEODE-9139 SSLException in starting up a Locator (#6308)(#6401)"
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #6690:
URL: https://github.com/apache/geode/pull/6690#discussion_r668094989
##########
File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/client/sni/DualServerSNIAcceptanceTest.java
##########
@@ -76,17 +76,8 @@ public static void beforeClass() {
docker.setContainerName("server-dolores", "server-dolores");
docker.setContainerName("server-clementine", "server-clementine");
Review comment:
these 3 docker.setContainerName calls go away as well
##########
File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/client/sni/DualServerSNIAcceptanceTest.java
##########
@@ -76,17 +76,8 @@ public static void beforeClass() {
docker.setContainerName("server-dolores", "server-dolores");
docker.setContainerName("server-clementine", "server-clementine");
Review comment:
these 3 docker.setContainerName calls can go away as well
##########
File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/client/sni/DualServerSNIAcceptanceTest.java
##########
@@ -76,17 +76,8 @@ public static void beforeClass() {
docker.setContainerName("server-dolores", "server-dolores");
docker.setContainerName("server-clementine", "server-clementine");
Review comment:
these 3 docker.setContainerName calls should go away as well to complete the revert and match how this looks on other branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #6690: Revert "GEODE-9139 SSLException in starting up a Locator (#6308)(#6401)"
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #6690:
URL: https://github.com/apache/geode/pull/6690#issuecomment-877441934
This pull request **introduces 1 alert** when merging ef6713ffb89e5c822adf2af4fe7443c95ae65aae into 9948cfe2bdd973fc73dd8d3d9da347f5628427dd - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-e8d65dbd8cbadb670fffc61fe58207f40969826b)
**new alerts:**
* 1 for Use of externally\-controlled format string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #6690: Revert "GEODE-9139 SSLException in starting up a Locator (#6308)(#6401)"
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #6690:
URL: https://github.com/apache/geode/pull/6690#discussion_r667560326
##########
File path: geode-assembly/src/acceptanceTest/java/org/apache/geode/client/sni/DualServerSNIAcceptanceTest.java
##########
@@ -59,7 +59,7 @@
public class DualServerSNIAcceptanceTest {
private static final URL DOCKER_COMPOSE_PATH =
- DualServerSNIAcceptanceTest.class.getResource("dual-server-docker-compose.yml");
+ SingleServerSNIAcceptanceTest.class.getResource("docker-compose.yml");
Review comment:
BeforeClass lines 75-89 also need to be reverted to:
```
docker.loggingExecForService("geode",
"gfsh", "run", "--file=/geode/scripts/geode-starter-2.gfsh");
```
Also, the file **dual-server-docker-compose.yml** should be deleted as part of this revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] nabarunnag merged pull request #6690: Revert "GEODE-9139 SSLException in starting up a Locator (#6308)(#6401)"
Posted by GitBox <gi...@apache.org>.
nabarunnag merged pull request #6690:
URL: https://github.com/apache/geode/pull/6690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #6690: Revert "GEODE-9139 SSLException in starting up a Locator (#6308)(#6401)"
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #6690:
URL: https://github.com/apache/geode/pull/6690#issuecomment-878460879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org