[GitHub] [tomcat] aooohan commented on pull request #646: Parameter error handling

["aooohan (via GitHub)" <gi...@apache.org>]

aooohan commented on PR #646:
URL: https://github.com/apache/tomcat/pull/646#issuecomment-1684798995

   This change look good for me.
   But I have found that `org.apache.catalina.valves.ExtendedAccessLogValve.RequestParameterElement` behavior is broken due to this change.  Maybe here should catch `InvalidParameterException`, right ? Also, we should check if exist others call `getParameterXXXX` internally after this change merged. : )
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org