You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by wido <gi...@git.apache.org> on 2016/07/06 08:00:55 UTC

[GitHub] libcloud pull request #834: auroradns: Change valid record types and impleme...

GitHub user wido opened a pull request:

    https://github.com/apache/libcloud/pull/834

    auroradns: Change valid record types and implement listing

    This commit changes the supported record types by Aurora DNS and it also
    supports listing the valid record types.
    
    It merely returns the keys of the RECORD_TYPE_MAP dict which is already
    available. In the future Aurora DNS should return this in a API call
    so this is no longer a static dictionary.
    
    This dict also contained a type 'SPF', which is not valid. SPF records
    are defined as TXT records in DNS. Remove this from the list of valid
    record types.
    
    Further it adds support for the SSHFP, DS, TLSA and PTR type since
    they are also supported.
    
    Also add tests to verify if this functions returns the proper values

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wido/libcloud auroradns-record-types

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #834
    
----
commit 8685a8504d3a6a9d8a259c214c5a1a221a34f445
Author: Wido den Hollander <wi...@widodh.nl>
Date:   2016-07-02T17:02:11Z

    auroradns: Change valid record types and implement listing
    
    This commit changes the supported record types by Aurora DNS and it also
    supports listing the valid record types.
    
    It merely returns the keys of the RECORD_TYPE_MAP dict which is already
    available. In the future Aurora DNS should return this in a API call
    so this is no longer a static dictionary.
    
    This dict also contained a type 'SPF', which is not valid. SPF records
    are defined as TXT records in DNS. Remove this from the list of valid
    record types.
    
    Further it adds support for the SSHFP, DS, TLSA and PTR type since
    they are also supported.
    
    Also add tests to verify if this functions returns the proper values

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] libcloud pull request #834: auroradns: Change valid record types and impleme...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/834


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---