You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "jrudolph (via GitHub)" <gi...@apache.org> on 2023/02/14 12:04:10 UTC
[GitHub] [incubator-pekko-http] jrudolph opened a new issue, #45: Upstream former DynamicRuleDispatch.lookup optimization to parboiled2
jrudolph opened a new issue, #45:
URL: https://github.com/apache/incubator-pekko-http/issues/45
Because we will likely remove that optimization in #14 by going back to upstream parboiled2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on issue #45: Upstream former DynamicRuleDispatch.lookup optimization to parboiled2
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on issue #45:
URL: https://github.com/apache/incubator-pekko-http/issues/45#issuecomment-1439648136
We shouldn't tackle that right now. It's a nice to have but not strictly required right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on issue #45: Upstream former DynamicRuleDispatch.lookup optimization to parboiled2
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #45:
URL: https://github.com/apache/incubator-pekko-http/issues/45#issuecomment-1564507259
Closing this since it has already been resolved (see https://github.com/sirthias/parboiled2/pull/419)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on issue #45: Upstream former DynamicRuleDispatch.lookup optimization to parboiled2
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #45:
URL: https://github.com/apache/incubator-pekko-http/issues/45#issuecomment-1439669357
> We shouldn't tackle that right now. It's a nice to have but not strictly required right now.
If the reason behind not tackling it right now is due to prioritisation then thats fair
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on issue #45: Upstream former DynamicRuleDispatch.lookup optimization to parboiled2
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #45:
URL: https://github.com/apache/incubator-pekko-http/issues/45#issuecomment-1438745797
We could but I am not entirely sure its necessary, the performance improvements don't seem to be that controversial or large in scope and it might be almost as fast just to create a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich closed issue #45: Upstream former DynamicRuleDispatch.lookup optimization to parboiled2
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed issue #45: Upstream former DynamicRuleDispatch.lookup optimization to parboiled2
URL: https://github.com/apache/incubator-pekko-http/issues/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on issue #45: Upstream former DynamicRuleDispatch.lookup optimization to parboiled2
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #45:
URL: https://github.com/apache/incubator-pekko-http/issues/45#issuecomment-1438726108
@jrudolph Do you want to work on this? I was thinking of having a look at it by end of week since it makes sense to upstream sooner rather than later (upstream changes take time to review)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning commented on issue #45: Upstream former DynamicRuleDispatch.lookup optimization to parboiled2
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #45:
URL: https://github.com/apache/incubator-pekko-http/issues/45#issuecomment-1438731742
Could we raise an issue in parboiled2 GitHub project? The 4 commits that @jrudolph highlighted look small enough and maybe, parboiled2 would agree to them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org