[jira] [Commented] (OMID-231) Build and test Omid with Hadoop 3

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OMID-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597886#comment-17597886 ] 

ASF GitHub Bot commented on OMID-231:
-------------------------------------

richardantal commented on code in PR #117:
URL: https://github.com/apache/phoenix-omid/pull/117#discussion_r958480217


##########
.gitignore:
##########
@@ -15,6 +15,7 @@ lib/
 *.iws
 *~
 *.swp
+^dev-support/artifacts

Review Comment:
   I don't think we need the `^` character
   
   Also I would add `dev-support/work` here too



##########
pom.xml:
##########
@@ -378,6 +378,8 @@
 
                         <!

> Build and test Omid with Hadoop 3
> ---------------------------------
>
>                 Key: OMID-231
>                 URL: https://issues.apache.org/jira/browse/OMID-231
>             Project: Phoenix Omid
>          Issue Type: Improvement
>    Affects Versions: 1.0.3
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> Based on a discussion on [dev@p.a.o, |mailto:dev@p.a.om]we want to build both the assembly and the public Omid maven artifacts with Hadoop 3.
> This requires changes to the poms, and we need to rebuild HBase in the CI script, just like we do in Phoenix.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)