[GitHub] [lucene-solr] dweiss commented on issue #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects

[GitBox <gi...@apache.org>]

dweiss commented on issue #1388: LUCENE-9278: Use -linkoffline instead of relative paths to make links to other projects
URL: https://github.com/apache/lucene-solr/pull/1388#issuecomment-609751515
 
 
   Hi Tomoko. I made a few minor changes. It is a contract of task.getTemporaryDir that the directory is exclusively owned by each task instance so I just simplified the checks there and overwrite any previous file. I also redirected the output to a temporary file and display it only if an error is thrown. I don't think we need to see the verbose messages from javadoc rendering (do we?). If we do then we could add a switch that would provide a TeeOutputStream (commons-io) and tee the output to the console as well.
   
   I ran it all on Windows and seems to be working. Please feel free to commit it in when you're ready.
   
   [patch.txt](https://github.com/apache/lucene-solr/files/4438204/patch.txt)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org