You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/23 06:17:32 UTC
[GitHub] [incubator-doris] jacktengg opened a new pull request, #9736: [bugfix] fix memleaks reported by ASAN
jacktengg opened a new pull request, #9736:
URL: https://github.com/apache/incubator-doris/pull/9736
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9736: [bugfix] fix memleaks reported by ASAN
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #9736:
URL: https://github.com/apache/incubator-doris/pull/9736#discussion_r879079416
##########
be/src/vec/exprs/vexpr.h:
##########
@@ -108,7 +108,13 @@ class VExpr {
VExpr* parent, int* node_idx, VExpr** root_expr,
VExprContext** ctx);
const std::vector<VExpr*>& children() const { return _children; }
- void set_children(std::vector<VExpr*> children) { _children = children; }
+ void set_children(RuntimeState* state, VExprContext* ctx, std::vector<VExpr*> children,
Review Comment:
this function old call in `dfs_peel_conjunct`, not need check `close_old`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jacktengg commented on a diff in pull request #9736: [bugfix] fix memleaks reported by ASAN
Posted by GitBox <gi...@apache.org>.
jacktengg commented on code in PR #9736:
URL: https://github.com/apache/incubator-doris/pull/9736#discussion_r879085624
##########
be/src/vec/exprs/vexpr.h:
##########
@@ -108,7 +108,13 @@ class VExpr {
VExpr* parent, int* node_idx, VExpr** root_expr,
VExprContext** ctx);
const std::vector<VExpr*>& children() const { return _children; }
- void set_children(std::vector<VExpr*> children) { _children = children; }
+ void set_children(RuntimeState* state, VExprContext* ctx, std::vector<VExpr*> children,
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9736: [bugfix] fix memleaks reported by ASAN
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9736:
URL: https://github.com/apache/incubator-doris/pull/9736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9736: [bugfix] fix memleaks reported by ASAN
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9736:
URL: https://github.com/apache/incubator-doris/pull/9736#issuecomment-1135326915
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9736: [bugfix] fix memleaks reported by ASAN
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9736:
URL: https://github.com/apache/incubator-doris/pull/9736#issuecomment-1135326929
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org