You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "dalelane (via GitHub)" <gi...@apache.org> on 2026/07/17 12:21:57 UTC
[PR] [FLINK-40163] [ci] Add new baseline nightly build to Github Actions [flink]
dalelane opened a new pull request, #28768:
URL: https://github.com/apache/flink/pull/28768
## What is the purpose of the change
Azure's nightly stage in tools/azure-pipelines/build-apache-repo.yml has cron_azure as a default baseline build, but there is no equivalent build in the Github Actions scheduled nightly pipeline.
The goal of this commit is to update the GHA nightly release pipeline towards parity with the AZP implementation, treating it as a reference.
## Brief change log
Added new Java 17 job to the GHA nightly release pipeline
## Verifying this change
Manually triggered the Github Actions pipeline in my own fork.
(see https://github.com/dalelane/flink/pull/3 )
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40163] [ci] Add new baseline nightly build to Github Actions [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28768:
URL: https://github.com/apache/flink/pull/28768#issuecomment-5003297139
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6e15bfe97a1153fa00de49ebd7f62ab0d60412a6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6e15bfe97a1153fa00de49ebd7f62ab0d60412a6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e15bfe97a1153fa00de49ebd7f62ab0d60412a6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40163] [ci] Add new baseline nightly build to Github Actions [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #28768:
URL: https://github.com/apache/flink/pull/28768#issuecomment-5004662377
@dalelane can you please explain why do we need it?
We already have java17 in default ci for merged PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40163] [ci] Add new baseline nightly build to Github Actions [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #28768:
URL: https://github.com/apache/flink/pull/28768#discussion_r3615281848
##########
.github/workflows/nightly.yml:
##########
@@ -43,6 +43,17 @@ jobs:
s3_bucket: ${{ secrets.IT_CASE_S3_BUCKET }}
s3_access_key: ${{ secrets.IT_CASE_S3_ACCESS_KEY }}
s3_secret_key: ${{ secrets.IT_CASE_S3_SECRET_KEY }}
+ java17:
+ name: "Java 17 (default)"
+ uses: ./.github/workflows/template.flink-ci.yml
+ with:
+ workflow-caller-id: java17
+ environment: 'PROFILE="-Dflink.hadoop.version=2.10.2 -Djdk17 -Pjava17-target"'
Review Comment:
why is this -Dflink.hadoop.version=2.10.2 but java 11 and 21 are -Dinclude_hadoop_aws
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40163] [ci] Add new baseline nightly build to Github Actions [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #28768:
URL: https://github.com/apache/flink/pull/28768#issuecomment-5045317970
> The reason I'm asking is that we have a limited resource for GHA
and Apache infra has already complained that we use too much, see for more details https://lists.apache.org/thread/jn9t7qjj4wlz98t1ddqxwypcn6g7wrds
I see - thanks for the pointer @snuyanzin. I wasn't aware of FLINK-39734. I just briefly remembered that we had increased GHA runner usage due to the ML dependency. As said in [my earlier comment](https://github.com/dalelane/flink/pull/3#pullrequestreview-4711239957), adding it was motivated by the fact that the AzureCI and GHA should be on par. But considering the concern from the infra side, I'm ok with documenting properly (through the created Jira subtask) why we do not add this job and leave it as `Won't Do` then. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40163] [ci] Add new baseline nightly build to Github Actions [flink]
Posted by "dalelane (via GitHub)" <gi...@apache.org>.
dalelane commented on PR #28768:
URL: https://github.com/apache/flink/pull/28768#issuecomment-5020485701
@snuyanzin The (_admittedly over-long!_) background is in https://issues.apache.org/jira/browse/FLINK-27075?focusedCommentId=18095329&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-18095329
The TLDR is that (given the overall objective to get the GHA pipelines to a point where they could be a viable replacement for the Azure pipelines) I looked to see where there were things done in the AZP pipeline with no equivalent in the GHA pipeline. The goal was parity, rather than coming at this from first principles to decide if it's needed in it's own right.
It's obviously entirely valid to take a step back and decide on whether it's needed, rather than just blindly copying it across (which, to be fair, @XComp did highlight in https://github.com/dalelane/flink/pull/3#pullrequestreview-4711239957 ) but I lack the context to have a strong opinion on that. I'm open to a steer from you and @XComp on what would be sensible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40163] [ci] Add new baseline nightly build to Github Actions [flink]
Posted by "dalelane (via GitHub)" <gi...@apache.org>.
dalelane commented on PR #28768:
URL: https://github.com/apache/flink/pull/28768#issuecomment-5057749283
That makes sense, thanks both.
@XComp - I don't have permission to change the state of the sub-task https://issues.apache.org/jira/browse/FLINK-40163 - are you able to do that please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40163] [ci] Add new baseline nightly build to Github Actions [flink]
Posted by "dalelane (via GitHub)" <gi...@apache.org>.
dalelane closed pull request #28768: [FLINK-40163] [ci] Add new baseline nightly build to Github Actions
URL: https://github.com/apache/flink/pull/28768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-40163] [ci] Add new baseline nightly build to Github Actions [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #28768:
URL: https://github.com/apache/flink/pull/28768#issuecomment-5004683275
The reason I'm asking is that we have a limited resource for GHA
and Apache infra has already complained that we use too much, see for more details https://lists.apache.org/thread/jn9t7qjj4wlz98t1ddqxwypcn6g7wrds
now if we add this it will be added to master and release branches (supported)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org