You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@eagle.apache.org by ha...@apache.org on 2016/09/08 07:38:45 UTC
incubator-eagle git commit: [minor] quick fix for checkstyle violation
Repository: incubator-eagle
Updated Branches:
refs/heads/master ecbdec8ef -> f45ec4370
[minor] quick fix for checkstyle violation
Project: http://git-wip-us.apache.org/repos/asf/incubator-eagle/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-eagle/commit/f45ec437
Tree: http://git-wip-us.apache.org/repos/asf/incubator-eagle/tree/f45ec437
Diff: http://git-wip-us.apache.org/repos/asf/incubator-eagle/diff/f45ec437
Branch: refs/heads/master
Commit: f45ec4370184b8563b1d170bd924a726c58bb9d1
Parents: ecbdec8
Author: Hao Chen <ha...@apache.org>
Authored: Thu Sep 8 15:38:26 2016 +0800
Committer: Hao Chen <ha...@apache.org>
Committed: Thu Sep 8 15:38:26 2016 +0800
----------------------------------------------------------------------
.../engine/router/impl/BasicStreamRoutePartitioner.java | 10 +++++-----
.../src/main/java/storm/kafka/KafkaSpoutMetric.java | 10 +++++-----
.../src/main/java/storm/kafka/KafkaSpoutWrapper.java | 6 +++---
3 files changed, 13 insertions(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-eagle/blob/f45ec437/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/router/impl/BasicStreamRoutePartitioner.java
----------------------------------------------------------------------
diff --git a/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/router/impl/BasicStreamRoutePartitioner.java b/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/router/impl/BasicStreamRoutePartitioner.java
index 9337bde..a97e1da 100644
--- a/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/router/impl/BasicStreamRoutePartitioner.java
+++ b/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/router/impl/BasicStreamRoutePartitioner.java
@@ -64,14 +64,14 @@ public class BasicStreamRoutePartitioner implements StreamRoutePartitioner {
}
protected List<StreamRoute> routeToAll(StreamEvent event) {
- if (_globalRoutingKeys != null) {
- _globalRoutingKeys = new ArrayList<>();
+ if (globalRoutingKeys != null) {
+ globalRoutingKeys = new ArrayList<>();
for (String targetId : outputComponentIds) {
- _globalRoutingKeys.add(new StreamRoute(targetId, -1, StreamPartition.Type.GLOBAL));
+ globalRoutingKeys.add(new StreamRoute(targetId, -1, StreamPartition.Type.GLOBAL));
}
}
- return _globalRoutingKeys;
+ return globalRoutingKeys;
}
- private List<StreamRoute> _globalRoutingKeys = null;
+ private List<StreamRoute> globalRoutingKeys = null;
}
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/incubator-eagle/blob/f45ec437/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/storm/kafka/KafkaSpoutMetric.java
----------------------------------------------------------------------
diff --git a/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/storm/kafka/KafkaSpoutMetric.java b/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/storm/kafka/KafkaSpoutMetric.java
index 341e665..935742f 100644
--- a/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/storm/kafka/KafkaSpoutMetric.java
+++ b/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/storm/kafka/KafkaSpoutMetric.java
@@ -36,14 +36,14 @@ public class KafkaSpoutMetric implements IMetric {
private Map<String, KafkaUtils.KafkaOffsetMetric> offsetMetricMap = new ConcurrentHashMap<>();
public static class KafkaSpoutMetricContext {
- SpoutConfig _spoutConfig;
- DynamicPartitionConnections _connections;
- PartitionCoordinator _coordinator;
+ SpoutConfig spoutConfig;
+ DynamicPartitionConnections connections;
+ PartitionCoordinator coordinator;
}
public void addTopic(String topic, KafkaSpoutMetricContext context) {
// construct KafkaOffsetMetric
- KafkaUtils.KafkaOffsetMetric kafkaOffsetMetric = new KafkaUtils.KafkaOffsetMetric(context._spoutConfig.topic, context._connections);
+ KafkaUtils.KafkaOffsetMetric kafkaOffsetMetric = new KafkaUtils.KafkaOffsetMetric(context.spoutConfig.topic, context.connections);
metricContextMap.put(topic, context);
offsetMetricMap.put(topic, kafkaOffsetMetric);
}
@@ -59,7 +59,7 @@ public class KafkaSpoutMetric implements IMetric {
HashMap spoutMetric = new HashMap();
for (Map.Entry<String, KafkaSpoutMetricContext> entry : metricContextMap.entrySet()) {
// construct offset metric
- List<PartitionManager> pms = entry.getValue()._coordinator.getMyManagedPartitions();
+ List<PartitionManager> pms = entry.getValue().coordinator.getMyManagedPartitions();
Set<Partition> latestPartitions = new HashSet();
for (PartitionManager pm : pms) {
latestPartitions.add(pm.getPartition());
http://git-wip-us.apache.org/repos/asf/incubator-eagle/blob/f45ec437/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/storm/kafka/KafkaSpoutWrapper.java
----------------------------------------------------------------------
diff --git a/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/storm/kafka/KafkaSpoutWrapper.java b/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/storm/kafka/KafkaSpoutWrapper.java
index 7ed9193..2bdbd3c 100644
--- a/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/storm/kafka/KafkaSpoutWrapper.java
+++ b/eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/storm/kafka/KafkaSpoutWrapper.java
@@ -90,9 +90,9 @@ public class KafkaSpoutWrapper extends KafkaSpout implements ISpoutSpecLCM {
// add new topic to metric
KafkaSpoutMetric.KafkaSpoutMetricContext metricContext = new KafkaSpoutMetric.KafkaSpoutMetricContext();
- metricContext._connections = _connections;
- metricContext._coordinator = _coordinator;
- metricContext._spoutConfig = _spoutConfig;
+ metricContext.connections = _connections;
+ metricContext.coordinator = _coordinator;
+ metricContext.spoutConfig = _spoutConfig;
kafkaSpoutMetric.addTopic(_spoutConfig.topic, metricContext);
this.collectorWrapper = (SpoutOutputCollectorWrapper) collector;