Re: [PR] Disable comment char in ArrayConverter list parsing [commons-beanutils]

["garydgregory (via GitHub)" <gi...@apache.org>]

garydgregory commented on code in PR #427:
URL: https://github.com/apache/commons-beanutils/pull/427#discussion_r3637935782


##########
src/test/java/org/apache/commons/beanutils2/converters/ArrayConverterTest.java:
##########
@@ -248,6 +248,23 @@ void testTheMatrix() {
         }
     }
 
+    /**
+     * A forward slash is not an allowed character, so it must split like any other separator (see {@link #testUnderscore_BEANUTILS_302()}) instead of commenting
+     * out the rest of the input and dropping the remaining elements.
+     */
+    @Test
+    void testForwardSlashSeparator() {
+        final String value = "first/value,second/value";
+        final ArrayConverter<String[]> converter = new ArrayConverter<>(String[].class, new StringConverter());
+        final String[] result = converter.convert(String[].class, value);
+        assertNotNull(result, "result.null");
+        assertEquals(4, result.length, "result.length");
+        assertEquals("first", result[0], "result[0]");

Review Comment:
   @rootvector2 
   
   Are you sure?
   
   The `/` now behaves the same as a `,`? That can't be right. Shouldn't the asserts be:
   ```java
   assertEquals("first/value", result[0]);
   assertEquals("second/value", result[1]);
   ```
   ?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org