[jira] [Commented] (HBASE-12437) HLogFactory should load WAL reader if custom user WAL reader fails instead of throwing InvalidProtocolBufferReaderException

["Sean Busbey (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-12437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200751#comment-14200751 ] 

Sean Busbey commented on HBASE-12437:
-------------------------------------

If the user provided a custom reader it's pretty dangerous for us to attempt to process them with some other reader blindly. esp if the fall back reader fails softly (that is, fails to read all the data but doesn't know it), because the logs will be archived/deleted.

Does the current IPBRE fail loudly with a message that the configured log reader is invalid?

> HLogFactory should load WAL reader if custom user WAL reader fails instead of throwing InvalidProtocolBufferReaderException
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12437
>                 URL: https://issues.apache.org/jira/browse/HBASE-12437
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 0.96.0, 0.98.4
>            Reporter: Enoch Hsu
>            Assignee: Enoch Hsu
>             Fix For: 1.0.0, 0.98.4
>
>
> The HLogFactory createReader function allows the user to create their own reader and just assumes that the reader will work correctly.
> In the case the user accidentally uses an incorrect reader and gets an InvalidProtocolBufferReaderException, HBase should have a safeguard to still allow HBase functions to execute.
> I propose that in this case HBase should default to the standard HBase readers.(ProtobufLogReader or  SequenceFIleLogReader)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)