You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/11/13 15:25:44 UTC

[GitHub] [skywalking-banyandb] mikechengwei commented on a diff in pull request #214: Fix stream's leaked goroutines

mikechengwei commented on code in PR #214:
URL: https://github.com/apache/skywalking-banyandb/pull/214#discussion_r1020920774


##########
banyand/metadata/schema/etcd.go:
##########
@@ -83,6 +83,7 @@ func (eh *eventHandler) InterestOf(kind Kind) bool {
 
 type etcdSchemaRegistry struct {
 	server   *embed.Etcd
+	client   *clientv3.Client

Review Comment:
   Because etcd client init at 
   https://github.com/apache/skywalking-banyandb/blob/c1302224dcb7e4113b0aef59d9005dd38f1eee30/banyand/metadata/schema/etcd.go#L168
   I need to convert the temporary variable to a property of `etcdSchemaRegistry `so that I can close the client resource.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org