You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2018/08/22 14:32:59 UTC
[GitHub] zeppelin pull request #3158: [ZEPPELIN-3740] Adopt `google-java-format` and ...
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/3158
[ZEPPELIN-3740] Adopt `google-java-format` and `fmt-maven-plugin`
### What is this PR for?
Avoiding outdated checkstyle error.
To check format
`mvn validate`
To fix non-complying files
`mvn fmt:format`
### What type of PR is it?
[Improvement | Refactoring]
### Todos
* [x] - Adopt `fmt-maven-plugin`
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3740
### How should this be tested?
CI passs
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes for contributors
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-3740
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3158.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3158
----
commit f8f28799d9f317e1b0bd9a7000f2aa1902fbeeb3
Author: Jongyoul Lee <jo...@...>
Date: 2018-08-21T08:45:04Z
Adopt `fmt-maven-plugin` for google-java-format
commit f36dbde41ce5f2636cf6132c08d9f24b3cbcef33
Author: Jongyoul Lee <jo...@...>
Date: 2018-08-21T09:31:21Z
Disable `maven-checkstyle-plugin` to `zeppelin-server` and `zeppelin-zengine`
Enable `fmt-maven-plugin` to `zeppelin-server` and `zeppelin-zengine`
commit c2f8c046dd7354a262bf9b63918a81b946119d4a
Author: Jongyoul Lee <jo...@...>
Date: 2018-08-22T06:35:04Z
Remove checkstyle plugin for all modules
commit 91a645e7111a8f4aaf806a30bd2407b24fbfec2e
Author: Jongyoul Lee <jo...@...>
Date: 2018-08-22T08:00:22Z
Enable `fmt-maven-plugin` for all modules
commit f4a960d98987d7d912af4fca361166de36ec0954
Author: Jongyoul Lee <jo...@...>
Date: 2018-08-22T08:57:40Z
Add configuration to show all un-complying files
commit 3b884735e5099bccfc86052401d4063db79a2707
Author: Jongyoul Lee <jo...@...>
Date: 2018-08-22T09:14:51Z
Adopt all files
----
---
[GitHub] zeppelin pull request #3158: [ZEPPELIN-3740] Adopt `google-java-format` and ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3158
---
[GitHub] zeppelin issue #3158: [ZEPPELIN-3740] Adopt `google-java-format` and `fmt-ma...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3158
Will merge if there’s no more discussion
---
[GitHub] zeppelin issue #3158: [ZEPPELIN-3740] Adopt `google-java-format` and `fmt-ma...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3158
https://travis-ci.org/jongyoul/zeppelin/builds/419215810
4th profiles is unstable now for the current master.
Will merge it if there's no more discussion
---
[GitHub] zeppelin issue #3158: [ZEPPELIN-3740] Adopt `google-java-format` and `fmt-ma...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3158
Agreed to maintain harder. This would be one of criteria. Actually, this formatter doesn't have to fix format manually, just run `mvn fmt:format` before rebasing it. I also started a discussion in dev@
---
[GitHub] zeppelin issue #3158: [ZEPPELIN-3740] Adopt `google-java-format` and `fmt-ma...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3158
@felixcheung IntelliJ's lambda format was not matched in our current checkstyle. I've tried to fix it by changing checkstyle, but I felt depressed because we should do every time whenever this inconsistency occurs. So I thought it would be better to change IDE's style and maven formatter to the same tool. That's the basic reason why I'd like to change style-related plugins
---
[GitHub] zeppelin issue #3158: [ZEPPELIN-3740] Adopt `google-java-format` and `fmt-ma...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3158
ok
---
[GitHub] zeppelin issue #3158: [ZEPPELIN-3740] Adopt `google-java-format` and `fmt-ma...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3158
I see. might be good to get some consensus first - we seem to be doing quite a bit of style changes in the last few months, it would make maintenance or backporting harder, for example.
---
[GitHub] zeppelin issue #3158: [ZEPPELIN-3740] Adopt `google-java-format` and `fmt-ma...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/3158
what's wrong with `maven-checkstyle-plugin`?
---