[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1314: ORC-1310: Allowlist Support for plugin filter

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on code in PR #1314:
URL: https://github.com/apache/orc/pull/1314#discussion_r1024252263


##########
java/core/src/java/org/apache/orc/OrcConf.java:
##########
@@ -190,6 +193,14 @@ public enum OrcConf {
                       + "determined, they are combined using AND. The order of application is "
                       + "non-deterministic and the filter functionality should not depend on the "
                       + "order of application."),
+
+  PLUGIN_FILTER_ALLOWLIST("orc.filter.plugin.allowlist",
+                          "orc.filter.plugin.allowlist",
+                          "",

Review Comment:
   It looks like a breaking change if this mean that we ban every plugins by default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org