[GitHub] [skywalking] stalary commented on a change in pull request #5129: Add jvm_thread metrics

[GitBox <gi...@apache.org>]

stalary commented on a change in pull request #5129:
URL: https://github.com/apache/skywalking/pull/5129#discussion_r456923098



##########
File path: oap-server/server-bootstrap/src/main/resources/oal/java-agent.oal
##########
@@ -25,4 +25,7 @@ instance_jvm_memory_noheap_max = from(ServiceInstanceJVMMemory.max).filter(heapS
 instance_jvm_young_gc_time = from(ServiceInstanceJVMGC.time).filter(phrase == GCPhrase.NEW).sum();
 instance_jvm_old_gc_time = from(ServiceInstanceJVMGC.time).filter(phrase == GCPhrase.OLD).sum();
 instance_jvm_young_gc_count = from(ServiceInstanceJVMGC.count).filter(phrase == GCPhrase.NEW).sum();
-instance_jvm_old_gc_count = from(ServiceInstanceJVMGC.count).filter(phrase == GCPhrase.OLD).sum();
\ No newline at end of file
+instance_jvm_old_gc_count = from(ServiceInstanceJVMGC.count).filter(phrase == GCPhrase.OLD).sum();
+instance_jvm_thread_live_count = from(ServiceInstanceThreadGC.liveCount).sum();
+instance_jvm_thread_daemon_count = from(ServiceInstanceThreadGC.daemonCount).sum();
+instance_jvm_thread_peak_count = from(ServiceInstanceThreadGC.peakCount).sum();

Review comment:
       Sorry, I was wrong here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org