You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/11/20 09:23:14 UTC

[GitHub] [iotdb] kr11 commented on a change in pull request #2034: Change listener to visitor in antlr in order to improve prase speed.

kr11 commented on a change in pull request #2034:
URL: https://github.com/apache/iotdb/pull/2034#discussion_r527557783



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/logical/crud/QueryOperator.java
##########
@@ -56,11 +57,31 @@
 
   private boolean ascending = true;
 
+  private Map<String, Object> props;

Review comment:
       "props" is a little general and may be confused if the original query involves other parameters/ properties, shall we rename it to "indexProps"?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org