You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Tristan Stevens <tr...@cloudera.com> on 2017/06/28 12:55:20 UTC
Re: Review Request 52955: FLUME-2698 - Upgrade Jetty Version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52955/
-----------------------------------------------------------
(Updated June 28, 2017, 12:55 p.m.)
Review request for Flume.
Changes
-------
Update for JDK1.8 and Jetty 9.4 changes.
Repository: flume-git
Description
-------
This patch upgrades the HTTPSource and HTTP Metrics server to Jetty 9.2 (N.B. 9.3/9.4 depend on JDK8). It also adds the ability to further configure the Jetty server and also run in multi-threaded mode. Finally, registered Jetty with the MBeans server to allow fine-grained performance tuning/monitoring if required.
Diffs (updated)
-----
flume-ng-core/pom.xml 2262d94f
flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 921a1f74
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 38bdfda6
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java 86caf7d7
flume-ng-core/src/main/java/org/apache/flume/tools/FlumeBeanConfigurator.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java 479cfc46
flume-ng-core/src/main/java/org/apache/flume/tools/ImmutablePair.java PRE-CREATION
flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java 09d419f4
flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java 475d92fe
flume-ng-core/src/test/java/org/apache/flume/source/http/TestBLOBHandler.java f770d511
flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 3ad82829
flume-ng-doc/sphinx/FlumeUserGuide.rst 2073bf63
flume-ng-legacy-sources/flume-avro-source/pom.xml 7cecde22
flume-ng-legacy-sources/flume-thrift-source/pom.xml 1ceeb5b5
flume-ng-sources/flume-scribe-source/pom.xml 73641dfd
pom.xml 5730db0c
Diff: https://reviews.apache.org/r/52955/diff/3/
Changes: https://reviews.apache.org/r/52955/diff/2-3/
Testing
-------
Passes existing unit tests, added specific tests for configurability aspects and also for JMX monitoring.
Thanks,
Tristan Stevens
Re: Review Request 52955: FLUME-2698 - Upgrade Jetty Version
Posted by Miklos Csanady <mi...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52955/#review184039
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Csanady
On Aug. 24, 2017, 8:32 p.m., Tristan Stevens wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52955/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2017, 8:32 p.m.)
>
>
> Review request for Flume.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> This patch upgrades the HTTPSource and HTTP Metrics server to Jetty 9.4. It also adds the ability to further configure the Jetty server and also run in multi-threaded mode. Finally, registered Jetty with the MBeans server to allow fine-grained performance tuning/monitoring if required.
>
>
> Diffs
> -----
>
> flume-ng-core/pom.xml e2ecd6ee
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 921a1f74
> flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 38bdfda6
> flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java 86caf7d7
> flume-ng-core/src/main/java/org/apache/flume/tools/FlumeBeanConfigurator.java PRE-CREATION
> flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java 479cfc46
> flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java 09d419f4
> flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java 475d92fe
> flume-ng-core/src/test/java/org/apache/flume/source/http/TestBLOBHandler.java f770d511
> flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 3ad82829
> flume-ng-doc/sphinx/FlumeUserGuide.rst 209db481
> flume-ng-legacy-sources/flume-avro-source/pom.xml 46d301b5
> flume-ng-legacy-sources/flume-thrift-source/pom.xml cb50473d
> flume-ng-sinks/flume-http-sink/pom.xml 3f8cfc88
> flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/FlumeHttpServletRequestWrapper.java 9711a3ad
> flume-ng-sources/flume-scribe-source/pom.xml 75fc085f
> pom.xml c0bd052b
>
>
> Diff: https://reviews.apache.org/r/52955/diff/6/
>
>
> Testing
> -------
>
> Passes existing unit tests, added specific tests for configurability aspects and also for JMX monitoring.
>
>
> File Attachments
> ----------------
>
> FLUME-2698-4.patch
> https://reviews.apache.org/media/uploaded/files/2017/07/17/b0a55da7-1b6a-4ae1-aea5-d6efa7a43c69__FLUME-2698-4.patch
>
>
> Thanks,
>
> Tristan Stevens
>
>
Re: Review Request 52955: FLUME-2698 - Upgrade Jetty Version
Posted by Tristan Stevens <tr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52955/
-----------------------------------------------------------
(Updated Aug. 24, 2017, 8:32 p.m.)
Review request for Flume.
Changes
-------
Fix checkstyle error
Repository: flume-git
Description
-------
This patch upgrades the HTTPSource and HTTP Metrics server to Jetty 9.4. It also adds the ability to further configure the Jetty server and also run in multi-threaded mode. Finally, registered Jetty with the MBeans server to allow fine-grained performance tuning/monitoring if required.
Diffs (updated)
-----
flume-ng-core/pom.xml e2ecd6ee
flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 921a1f74
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 38bdfda6
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java 86caf7d7
flume-ng-core/src/main/java/org/apache/flume/tools/FlumeBeanConfigurator.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java 479cfc46
flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java 09d419f4
flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java 475d92fe
flume-ng-core/src/test/java/org/apache/flume/source/http/TestBLOBHandler.java f770d511
flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 3ad82829
flume-ng-doc/sphinx/FlumeUserGuide.rst 209db481
flume-ng-legacy-sources/flume-avro-source/pom.xml 46d301b5
flume-ng-legacy-sources/flume-thrift-source/pom.xml cb50473d
flume-ng-sinks/flume-http-sink/pom.xml 3f8cfc88
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/FlumeHttpServletRequestWrapper.java 9711a3ad
flume-ng-sources/flume-scribe-source/pom.xml 75fc085f
pom.xml c0bd052b
Diff: https://reviews.apache.org/r/52955/diff/6/
Changes: https://reviews.apache.org/r/52955/diff/5-6/
Testing
-------
Passes existing unit tests, added specific tests for configurability aspects and also for JMX monitoring.
File Attachments
----------------
FLUME-2698-4.patch
https://reviews.apache.org/media/uploaded/files/2017/07/17/b0a55da7-1b6a-4ae1-aea5-d6efa7a43c69__FLUME-2698-4.patch
Thanks,
Tristan Stevens
Re: Review Request 52955: FLUME-2698 - Upgrade Jetty Version
Posted by Tristan Stevens <tr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52955/
-----------------------------------------------------------
(Updated Aug. 24, 2017, 5:41 p.m.)
Review request for Flume.
Changes
-------
Update following comments received offline
Repository: flume-git
Description
-------
This patch upgrades the HTTPSource and HTTP Metrics server to Jetty 9.4. It also adds the ability to further configure the Jetty server and also run in multi-threaded mode. Finally, registered Jetty with the MBeans server to allow fine-grained performance tuning/monitoring if required.
Diffs (updated)
-----
flume-ng-core/pom.xml e2ecd6ee
flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 921a1f74
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 38bdfda6
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java 86caf7d7
flume-ng-core/src/main/java/org/apache/flume/tools/FlumeBeanConfigurator.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java 479cfc46
flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java 09d419f4
flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java 475d92fe
flume-ng-core/src/test/java/org/apache/flume/source/http/TestBLOBHandler.java f770d511
flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 3ad82829
flume-ng-doc/sphinx/FlumeUserGuide.rst 209db481
flume-ng-legacy-sources/flume-avro-source/pom.xml 46d301b5
flume-ng-legacy-sources/flume-thrift-source/pom.xml cb50473d
flume-ng-sinks/flume-http-sink/pom.xml 3f8cfc88
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/FlumeHttpServletRequestWrapper.java 9711a3ad
flume-ng-sources/flume-scribe-source/pom.xml 75fc085f
pom.xml c0bd052b
Diff: https://reviews.apache.org/r/52955/diff/5/
Changes: https://reviews.apache.org/r/52955/diff/4-5/
Testing
-------
Passes existing unit tests, added specific tests for configurability aspects and also for JMX monitoring.
File Attachments
----------------
FLUME-2698-4.patch
https://reviews.apache.org/media/uploaded/files/2017/07/17/b0a55da7-1b6a-4ae1-aea5-d6efa7a43c69__FLUME-2698-4.patch
Thanks,
Tristan Stevens
Re: Review Request 52955: FLUME-2698 - Upgrade Jetty Version
Posted by Tristan Stevens <tr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52955/
-----------------------------------------------------------
(Updated July 17, 2017, 7:06 p.m.)
Review request for Flume.
Changes
-------
Change description and update following comments.
Repository: flume-git
Description (updated)
-------
This patch upgrades the HTTPSource and HTTP Metrics server to Jetty 9.4. It also adds the ability to further configure the Jetty server and also run in multi-threaded mode. Finally, registered Jetty with the MBeans server to allow fine-grained performance tuning/monitoring if required.
Diffs (updated)
-----
flume-ng-core/pom.xml 2262d94f
flume-ng-core/src/main/java/org/apache/flume/instrumentation/http/HTTPMetricsServer.java 921a1f74
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java 38bdfda6
flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java 86caf7d7
flume-ng-core/src/main/java/org/apache/flume/tools/FlumeBeanConfigurator.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/tools/HTTPServerConstraintUtil.java 479cfc46
flume-ng-core/src/main/java/org/apache/flume/tools/ImmutablePair.java PRE-CREATION
flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java 09d419f4
flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java 475d92fe
flume-ng-core/src/test/java/org/apache/flume/source/http/TestBLOBHandler.java f770d511
flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java 3ad82829
flume-ng-doc/sphinx/FlumeUserGuide.rst 209db481
flume-ng-legacy-sources/flume-avro-source/pom.xml 7cecde22
flume-ng-legacy-sources/flume-thrift-source/pom.xml 1ceeb5b5
flume-ng-sources/flume-scribe-source/pom.xml 73641dfd
pom.xml 5730db0c
Diff: https://reviews.apache.org/r/52955/diff/4/
Changes: https://reviews.apache.org/r/52955/diff/3-4/
Testing
-------
Passes existing unit tests, added specific tests for configurability aspects and also for JMX monitoring.
File Attachments (updated)
----------------
FLUME-2698-4.patch
https://reviews.apache.org/media/uploaded/files/2017/07/17/b0a55da7-1b6a-4ae1-aea5-d6efa7a43c69__FLUME-2698-4.patch
Thanks,
Tristan Stevens