You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "Chris Egerton (Jira)" <ji...@apache.org> on 2022/06/17 20:26:00 UTC

[jira] [Created] (KAFKA-14007) Connect header converters never closed

Chris Egerton created KAFKA-14007:
-------------------------------------

             Summary: Connect header converters never closed
                 Key: KAFKA-14007
                 URL: https://issues.apache.org/jira/browse/KAFKA-14007
             Project: Kafka
          Issue Type: Bug
          Components: KafkaConnect
            Reporter: Chris Egerton


The [HeaderConverter interface|https://github.com/apache/kafka/blob/1e21201ea24389bdaccb8a462f3a53e356b58a58/connect/api/src/main/java/org/apache/kafka/connect/storage/HeaderConverter.java#L27] extends {{Closeable}}, but {{HeaderConverter::close}} is never actually invoked anywhere. We can and should start invoking it, probably wrapped in [Utils::closeQuietly|https://github.com/apache/kafka/blob/1e21201ea24389bdaccb8a462f3a53e356b58a58/clients/src/main/java/org/apache/kafka/common/utils/Utils.java#L999-L1010] so that any invalid logic in that method for custom header converters that has to date gone undetected will not cause new task failures.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)