[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #13055: feat(i18n): add translations of FI/ES/TH for time formatter.

[GitBox <gi...@apache.org>]

Ovilia commented on a change in pull request #13055:
URL: https://github.com/apache/incubator-echarts/pull/13055#discussion_r463350612



##########
File path: i18n/langES-obj.js
##########
@@ -41,6 +41,22 @@
 
 
 var localeObj = {
+    time: {
+        month: [
+            'Enero', 'Febrero', 'Marzo', 'Abril', 'Mayo', 'Junio',

Review comment:
       Spanish doesn't capitalize on month or day-of-week names. So it should be `'enero'` and etc.

##########
File path: src/i18n/langES.ts
##########
@@ -18,6 +18,22 @@
  */
 
 export default {
+    time: {
+        month: [
+            'Enero', 'Febrero', 'Marzo', 'Abril', 'Mayo', 'Junio',

Review comment:
       Same here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org