[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9359: ARROW-11426: [Rust][DataFusion] EXTRACT support

[GitBox <gi...@apache.org>]

jorgecarleitao commented on a change in pull request #9359:
URL: https://github.com/apache/arrow/pull/9359#discussion_r567202041



##########
File path: rust/datafusion/src/logical_plan/expr.rs
##########
@@ -169,6 +170,13 @@ pub enum Expr {
     },
     /// Represents a reference to all fields in a schema.
     Wildcard,
+    /// Extract date parts (day, hour, minute) from a date / time expression
+    Extract {

Review comment:
       I have been trying to move them to the `ScalarFunction` to avoid having many variants around, mostly because adding a new item to an enum is backward incompatible and thus it may be beneficial to reserve that for operations that cannot be described by `ScalarFunction`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org