[jira] Commented: (VELOCITY-618) Strict property and method references

["Nathan Bubna (JIRA)" <de...@velocity.apache.org>]

    [ https://issues.apache.org/jira/browse/VELOCITY-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636208#action_12636208 ] 

Nathan Bubna commented on VELOCITY-618:
---------------------------------------

at first glance, i see two problems:

- I recently fixed the "issue of #if statements being ignored because one of the sides of the comparison is null, or non-existent".  This doesn't require a strict mode being enabled to allow it.  So, the changes to ASTNENode and ASTEQNode are extraneous. :)

- i don't see any reason to make uberInfo a public field in ASTReference

Otherwise, it looks good.  I can see people using this too, and i don't really have any problem with allowing null values to be kept/set in the context as long as it still passes the test suite.  Speaking of which, would you be willing to create a test case for these changes/features?  It would make it a lot easier for me to get these changes in and would help ensure no one breaks them in the future.

> Strict property and method references
> -------------------------------------
>
>                 Key: VELOCITY-618
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-618
>             Project: Velocity
>          Issue Type: Improvement
>          Components: Engine
>            Reporter: Byron Foster
>         Attachments: strictPropertyAndVariable.patch, strictPropertyRef.patch
>
>
> The given patch against trunk adds a new option 'runtime.references.strict'.  When set to true, invalid property references will throw a InvalidMethodException.  For example $foo.bar will throw an exception if the object contained in $foo has no such property as bar.  Any kind of reference to bar will cause an exception including:
> #if(#foo.bar)
> #set($foo.bar = "junk")
> #set($foo.getBar())
> etc...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org