You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "feuillatte (via GitHub)" <gi...@apache.org> on 2025/11/15 22:29:39 UTC
[PR] GH-48139: [C++] Allow compilation for QNX versions up to 8 [arrow]
feuillatte opened a new pull request, #48140:
URL: https://github.com/apache/arrow/pull/48140
### Rationale for this change
The endianness header inclusion preprocessor selection logic in `cpp/src/arrow/util/endian.h` currently prevents compling Arrow C++ libraries for the QNX operating system. Modern QNX operating system toolchains are detectable via the preprocessor defines `__QNXNTO__` (versions 5 - 7) and `__QNX__` (version 8), which are not currently considered, but the basis for the logic is already implemented for AIX.
### What changes are included in this PR?
Extend the current preprocessor `!defined()` check for AIX with the equivalent for QNX in `cpp/src/arrow/util/endian.h`.
### Are these changes tested?
The change is verified using the proprietary QNX SDP 7.1 GCC 8 based toolchain and tested on QNX 7. Applying the patch allows building for QNX.
### Are there any user-facing changes?
No; the changes purely relate to OS-specific toolchain detection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48139: [C++] Allow compilation for QNX versions up to 8 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #48140:
URL: https://github.com/apache/arrow/pull/48140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48139: [C++] Allow compilation for QNX versions up to 8 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48140:
URL: https://github.com/apache/arrow/pull/48140#issuecomment-3546197512
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit dbbe0ee148f6859d41e77035df842cf5b1f6843c.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/55680147844) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48139: [C++] Allow compilation for QNX versions up to 8 [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #48140:
URL: https://github.com/apache/arrow/pull/48140#issuecomment-3540567599
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48139: [C++] Allow compilation for QNX versions up to 8 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48140:
URL: https://github.com/apache/arrow/pull/48140#issuecomment-3540577122
Revision: ed2539495934f0931bda9c2fb3bcb89f29a47fa0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2b9d648d3a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2b9d648d3a)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/19423401222/job/55565252088)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/19423401024/job/55565251324)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/19423400852/job/55565250653)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/19423401505/job/55565252912)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/19423401130/job/55565251709)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/19423400976/job/55565251171)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/19423401217/job/55565252046)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/19423401258/job/55565252087)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/19423401087/job/55565251530)|
|test-fedora-42-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/19423400721/job/55565250244)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/19423401016/job/55565251316)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/19423400614/job/55565249823)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/19423401080/job/55565251526)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/19423401229/job/55565252031)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/19423400890/job/55565250846)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/19423400962/job/55565251147)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/19423401127/job/55565251691)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/19423400789/job/55565250419)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/19423400772/job/55565250500)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/19423400556/job/55565249640)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/19423400923/job/55565251018)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org