You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Gus Heck (JIRA)" <ji...@apache.org> on 2017/10/15 21:16:02 UTC

[jira] [Created] (SOLR-11493) Unnecessary creation of singlton lists in DistributedUpdateProcessor

Gus Heck created SOLR-11493:
-------------------------------

             Summary: Unnecessary creation of singlton lists in DistributedUpdateProcessor
                 Key: SOLR-11493
                 URL: https://issues.apache.org/jira/browse/SOLR-11493
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
          Components: SolrCloud
            Reporter: Gus Heck
            Priority: Minor


I thought I'd found another bug because one of 4 variants didn't have a loop, but then I noticed that the method in question was being fed a list, and the very first thing it does is loop that list... so it seems there is no need to loop the list, create and pass in a singleton list, and then have the method loop that singleton list to process a single item... 

Fixing this should save us a bit of object creation & therefore reduce GC load.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org