[GitHub] [cordova-ios] raphinesse edited a comment on issue #719: Add check for newer versions of cocoapods to avoid locking adding platforms on non synced pods repo

[GitBox <gi...@apache.org>]

raphinesse edited a comment on issue #719: Add check for newer versions of cocoapods to avoid locking adding platforms on non synced pods repo
URL: https://github.com/apache/cordova-ios/pull/719#issuecomment-555995269
 
 
   @renanccastro When giving the code a thorough review, I noticed that we already get the cocoapods version passed in as part of the result from the `check_cocoapod_tool` call. I updated your code to use that and also used `versions.compareVersions` which internally uses `semver` but also gracefully handles non-semver versions.
   
   It would be great to have a unit test that checks the behavior for pod versions starting with `1.8.0`. Other than that, this is good to go for me now. Hopefully we can include this in the upcoming release. In any case: thanks for your contribution and patience.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org