You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2022/02/02 19:45:11 UTC

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #707: [PARQUET-1719] Make ParquetReader(List, ParquetReadOptions, ReadSupport) constructor public

shangxinli commented on a change in pull request #707:
URL: https://github.com/apache/parquet-mr/pull/707#discussion_r797956093



##########
File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetReader.java
##########
@@ -115,9 +115,9 @@ private ParquetReader(Configuration conf,
         readSupport);
   }
 
-  private ParquetReader(List<InputFile> files,
-                        ParquetReadOptions options,
-                        ReadSupport<T> readSupport) throws IOException {
+  public ParquetReader(List<InputFile> files,

Review comment:
       Since it is going be public, please add comments like above. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org