You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/29 23:51:38 UTC
[GitHub] [superset] pkdotson opened a new pull request #16910: chore: add certified columns to top of list
pkdotson opened a new pull request #16910:
URL: https://github.com/apache/superset/pull/16910
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This pr add certified columns to top of datasourcepanel list. This pr is follow up
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
https://user-images.githubusercontent.com/17326228/135363783-13a544ba-324b-47c2-82a0-a76000f924ec.mov
after
https://user-images.githubusercontent.com/17326228/135363680-6a76da36-861a-4a1f-b62a-fbcef187d39b.mov
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #16910:
URL: https://github.com/apache/superset/pull/16910#discussion_r720218715
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -253,6 +257,12 @@ export default function DataSourcePanel({
setInputValue('');
}, [columns, datasource, metrics]);
+ const sortCertifiedFirst = (slice: ColumnMeta[]) => {
Review comment:
@villebro I think the order is retained. Here is a short demo https://jsfiddle.net/9c0fjpwv/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #16910:
URL: https://github.com/apache/superset/pull/16910#discussion_r719669773
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -253,6 +257,12 @@ export default function DataSourcePanel({
setInputValue('');
}, [columns, datasource, metrics]);
+ const sortCertifiedFirst = (slice: ColumnMeta[]) => {
Review comment:
Does this retain the order within the certified vs non-certified groups? Doing it like it's done here should at least ensure the order is retained.
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -253,6 +257,12 @@ export default function DataSourcePanel({
setInputValue('');
}, [columns, datasource, metrics]);
+ const sortCertifiedFirst = (slice: ColumnMeta[]) => {
Review comment:
Does the proposed change retain the order within the certified vs non-certified groups? Doing it like it's done here should at least ensure the order is retained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #16910:
URL: https://github.com/apache/superset/pull/16910#discussion_r719199104
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -253,6 +257,12 @@ export default function DataSourcePanel({
setInputValue('');
}, [columns, datasource, metrics]);
+ const sortCertifiedFirst = (slice: ColumnMeta[]) => {
Review comment:
I think here for brevity you could just sort the slice array, something like:
`slice.sort((a, b) => (b. is_certified - a. is_certified));`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16910:
URL: https://github.com/apache/superset/pull/16910#issuecomment-930644119
# [Codecov](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16910](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1e4704) into [master](https://codecov.io/gh/apache/superset/commit/4da4fe4136a6b2f0687d8a699a472fb7962c5576?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4da4fe4) will **increase** coverage by `0.00%`.
> The diff coverage is `83.33%`.
> :exclamation: Current head d1e4704 differs from pull request most recent head c6e6607. Consider uploading reports for the commit c6e6607 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16910 +/- ##
=======================================
Coverage 77.02% 77.03%
=======================================
Files 1022 1021 -1
Lines 54857 54853 -4
Branches 7482 7481 -1
=======================================
Hits 42256 42256
+ Misses 12354 12350 -4
Partials 247 247
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.14% <83.33%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `75.00% <83.33%> (+1.04%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `61.94% <0.00%> (-1.42%)` | :arrow_down: |
| [superset-frontend/src/api/dataset.ts](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FwaS9kYXRhc2V0LnRz) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4da4fe4...c6e6607](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16910:
URL: https://github.com/apache/superset/pull/16910#issuecomment-930644119
# [Codecov](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16910](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a0423ce) into [master](https://codecov.io/gh/apache/superset/commit/4da4fe4136a6b2f0687d8a699a472fb7962c5576?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4da4fe4) will **decrease** coverage by `0.04%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16910 +/- ##
==========================================
- Coverage 77.02% 76.98% -0.05%
==========================================
Files 1022 1023 +1
Lines 54857 54909 +52
Branches 7482 7486 +4
==========================================
+ Hits 42256 42269 +13
- Misses 12354 12392 +38
- Partials 247 248 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.04% <75.00%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `74.48% <75.00%> (+0.53%)` | :arrow_up: |
| [...ersConfigModal/FiltersConfigForm/DatasetSelect.tsx](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RhdGFzZXRTZWxlY3QudHN4) | `48.48% <0.00%> (-36.37%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `61.94% <0.00%> (-1.42%)` | :arrow_down: |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `70.88% <0.00%> (-1.34%)` | :arrow_down: |
| [...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50L2luZGV4LnRzeA==) | `72.54% <0.00%> (-0.43%)` | :arrow_down: |
| [superset-frontend/src/views/menu.tsx](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL21lbnUudHN4) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Icons/index.tsx](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaW5kZXgudHN4) | `100.00% <0.00%> (ø)` | |
| [...d/src/filters/components/Time/TimeFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL1RpbWVGaWx0ZXJQbHVnaW4udHN4) | `86.66% <0.00%> (ø)` | |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `73.83% <0.00%> (ø)` | |
| [superset-frontend/src/api/dataset.ts](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FwaS9kYXRhc2V0LnRz) | | |
| ... and [8 more](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4da4fe4...a0423ce](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on a change in pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
pkdotson commented on a change in pull request #16910:
URL: https://github.com/apache/superset/pull/16910#discussion_r720372124
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -253,6 +257,12 @@ export default function DataSourcePanel({
setInputValue('');
}, [columns, datasource, metrics]);
+ const sortCertifiedFirst = (slice: ColumnMeta[]) => {
Review comment:
Yes this works thanks for the suggesiton.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16910:
URL: https://github.com/apache/superset/pull/16910#issuecomment-931021435
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson merged pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
pkdotson merged pull request #16910:
URL: https://github.com/apache/superset/pull/16910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16910:
URL: https://github.com/apache/superset/pull/16910#issuecomment-930644119
# [Codecov](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16910](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1e4704) into [master](https://codecov.io/gh/apache/superset/commit/4da4fe4136a6b2f0687d8a699a472fb7962c5576?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4da4fe4) will **increase** coverage by `0.00%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16910 +/- ##
=======================================
Coverage 77.02% 77.03%
=======================================
Files 1022 1021 -1
Lines 54857 54853 -4
Branches 7482 7481 -1
=======================================
Hits 42256 42256
+ Misses 12354 12350 -4
Partials 247 247
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.14% <83.33%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `75.00% <83.33%> (+1.04%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `61.94% <0.00%> (-1.42%)` | :arrow_down: |
| [superset-frontend/src/api/dataset.ts](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FwaS9kYXRhc2V0LnRz) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4da4fe4...d1e4704](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16910:
URL: https://github.com/apache/superset/pull/16910#discussion_r720373038
##########
File path: superset-frontend/src/explore/components/controls/FilterControl/AdhocFilter/index.js
##########
@@ -154,19 +154,24 @@ export default class AdhocFilter {
op => OPERATOR_ENUM_TO_OPERATOR_TYPE[op].operation,
);
if (this.expressionType === EXPRESSION_TYPES.SIMPLE) {
+ // console.log('isValid Meth', this.expressionType)
if (nullCheckOperators.indexOf(this.operator) >= 0) {
+ // console.log('Null Op --> opertator', this.operator)
+ // console.log('subject', this.subject)
return !!(this.operator && this.subject);
}
if (truthCheckOperators.indexOf(this.operator) >= 0) {
+ // console.log('i hit in truthCheckers', this.subject)
Review comment:
```suggestion
```
##########
File path: superset-frontend/src/explore/components/controls/FilterControl/AdhocFilter/index.js
##########
@@ -154,19 +154,24 @@ export default class AdhocFilter {
op => OPERATOR_ENUM_TO_OPERATOR_TYPE[op].operation,
);
if (this.expressionType === EXPRESSION_TYPES.SIMPLE) {
+ // console.log('isValid Meth', this.expressionType)
Review comment:
```suggestion
```
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -253,6 +257,11 @@ export default function DataSourcePanel({
setInputValue('');
}, [columns, datasource, metrics]);
+ const sortCertifiedFirst = (slice: ColumnMeta[]) => {
+ const sorted = slice.sort((a, b) => b.is_certified - a.is_certified);
+ return sorted;
+ };
Review comment:
```suggestion
const sortCertifiedFirst = (slice: ColumnMeta[]) =>
slice.sort((a, b) => b.is_certified - a.is_certified);
```
##########
File path: superset-frontend/src/explore/components/controls/FilterControl/AdhocFilter/index.js
##########
@@ -154,19 +154,24 @@ export default class AdhocFilter {
op => OPERATOR_ENUM_TO_OPERATOR_TYPE[op].operation,
);
if (this.expressionType === EXPRESSION_TYPES.SIMPLE) {
+ // console.log('isValid Meth', this.expressionType)
if (nullCheckOperators.indexOf(this.operator) >= 0) {
+ // console.log('Null Op --> opertator', this.operator)
+ // console.log('subject', this.subject)
return !!(this.operator && this.subject);
}
if (truthCheckOperators.indexOf(this.operator) >= 0) {
+ // console.log('i hit in truthCheckers', this.subject)
return !!(this.subject && this.comparator !== null);
}
if (this.operator && this.subject && this.clause) {
+ // console.log('i trio check', this.operator, 'subject ->', this.subject, 'clause', this.clause)
Review comment:
```suggestion
```
##########
File path: superset-frontend/src/explore/components/controls/FilterControl/AdhocFilter/index.js
##########
@@ -154,19 +154,24 @@ export default class AdhocFilter {
op => OPERATOR_ENUM_TO_OPERATOR_TYPE[op].operation,
);
if (this.expressionType === EXPRESSION_TYPES.SIMPLE) {
+ // console.log('isValid Meth', this.expressionType)
if (nullCheckOperators.indexOf(this.operator) >= 0) {
+ // console.log('Null Op --> opertator', this.operator)
+ // console.log('subject', this.subject)
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16910:
URL: https://github.com/apache/superset/pull/16910#discussion_r719301293
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -253,6 +257,12 @@ export default function DataSourcePanel({
setInputValue('');
}, [columns, datasource, metrics]);
+ const sortCertifiedFirst = (slice: ColumnMeta[]) => {
Review comment:
Agreed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #16910:
URL: https://github.com/apache/superset/pull/16910#discussion_r720218715
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -253,6 +257,12 @@ export default function DataSourcePanel({
setInputValue('');
}, [columns, datasource, metrics]);
+ const sortCertifiedFirst = (slice: ColumnMeta[]) => {
Review comment:
@villebro I think the order is retained. Here is a short demo https://jsfiddle.net/4m8g2nvs/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #16910:
URL: https://github.com/apache/superset/pull/16910#issuecomment-930644119
# [Codecov](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16910](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1e4704) into [master](https://codecov.io/gh/apache/superset/commit/4da4fe4136a6b2f0687d8a699a472fb7962c5576?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4da4fe4) will **increase** coverage by `0.00%`.
> The diff coverage is `83.33%`.
> :exclamation: Current head d1e4704 differs from pull request most recent head a0423ce. Consider uploading reports for the commit a0423ce to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16910 +/- ##
=======================================
Coverage 77.02% 77.03%
=======================================
Files 1022 1021 -1
Lines 54857 54853 -4
Branches 7482 7481 -1
=======================================
Hits 42256 42256
+ Misses 12354 12350 -4
Partials 247 247
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.14% <83.33%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `75.00% <83.33%> (+1.04%)` | :arrow_up: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `61.94% <0.00%> (-1.42%)` | :arrow_down: |
| [superset-frontend/src/api/dataset.ts](https://codecov.io/gh/apache/superset/pull/16910/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FwaS9kYXRhc2V0LnRz) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4da4fe4...a0423ce](https://codecov.io/gh/apache/superset/pull/16910?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16910:
URL: https://github.com/apache/superset/pull/16910#issuecomment-932472912
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16910: chore: add certified columns to top of list
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16910:
URL: https://github.com/apache/superset/pull/16910#issuecomment-931025891
@geido Ephemeral environment spinning up at http://54.201.52.174:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org