You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Alexander Thomas <al...@collab.net> on 2011/09/23 14:39:53 UTC

[PATCH] fix build failure when configured using --without-zlib

All,

AFAIK, Subversion cannot be build without zlib. At present if configured
using '--without-zlib' or '--with-zlib=no' options, build will fail with
following error message ...
[[[
Subversion/trunk/libtool: line 4992: cd: no/lib: No such file or
directory
libtool: link: cannot determine absolute directory name of `no/lib'
]]]

[[[
Fixes build failure when configured with '--without-zlib'.

* build/ac-macros/zlib.m4
  (SVN_LIB_Z): Configure error-outs if executed with '--without-zlib'
   or '--with-zlib=no' options.

Patch by: Alexander Thomas <al...@collab.net>
]]]


-Alexander Thomas(AT)

Re: [PATCH] fix build failure when configured using --without-zlib

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Mark Phippard wrote on Fri, Sep 23, 2011 at 08:43:02 -0400:
> I thought zlib became mandatory a few releases back?  Isn't it used as
> part of svndiff1 or something like that?
> 

Yes, and the servers/clients advertise svndiff1 as part of the protocol
greeting; if they don't have zlib but advertise svndiff1 they will get
nowhere fast.

Alexander: your log message does not say HOW you fix the failure ---
i.e., do you fix the error message or make it go away.

> 
> On Fri, Sep 23, 2011 at 8:39 AM, Alexander Thomas <al...@collab.net> wrote:
> > All,
> >
> > AFAIK, Subversion cannot be build without zlib. At present if configured
> > using '--without-zlib' or '--with-zlib=no' options, build will fail with
> > following error message ...
> > [[[
> > Subversion/trunk/libtool: line 4992: cd: no/lib: No such file or
> > directory
> > libtool: link: cannot determine absolute directory name of `no/lib'
> > ]]]
> >
> > [[[
> > Fixes build failure when configured with '--without-zlib'.
> >
> > * build/ac-macros/zlib.m4
> >  (SVN_LIB_Z): Configure error-outs if executed with '--without-zlib'
> >   or '--with-zlib=no' options.
> >
> > Patch by: Alexander Thomas <al...@collab.net>
> > ]]]
> >
> >
> > -Alexander Thomas(AT)
> >
> 
> 
> 
> -- 
> Thanks
> 
> Mark Phippard
> http://markphip.blogspot.com/

Re: [PATCH] fix build failure when configured using --without-zlib

Posted by Mark Phippard <ma...@gmail.com>.
I thought zlib became mandatory a few releases back?  Isn't it used as
part of svndiff1 or something like that?


On Fri, Sep 23, 2011 at 8:39 AM, Alexander Thomas <al...@collab.net> wrote:
> All,
>
> AFAIK, Subversion cannot be build without zlib. At present if configured
> using '--without-zlib' or '--with-zlib=no' options, build will fail with
> following error message ...
> [[[
> Subversion/trunk/libtool: line 4992: cd: no/lib: No such file or
> directory
> libtool: link: cannot determine absolute directory name of `no/lib'
> ]]]
>
> [[[
> Fixes build failure when configured with '--without-zlib'.
>
> * build/ac-macros/zlib.m4
>  (SVN_LIB_Z): Configure error-outs if executed with '--without-zlib'
>   or '--with-zlib=no' options.
>
> Patch by: Alexander Thomas <al...@collab.net>
> ]]]
>
>
> -Alexander Thomas(AT)
>



-- 
Thanks

Mark Phippard
http://markphip.blogspot.com/

Re: [PATCH] fix build failure when configured using --without-zlib

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Applied, with a new log message.

Alexander Thomas wrote on Fri, Sep 23, 2011 at 18:09:53 +0530:
> All,
> 
> AFAIK, Subversion cannot be build without zlib. At present if configured
> using '--without-zlib' or '--with-zlib=no' options, build will fail with
> following error message ...
> [[[
> Subversion/trunk/libtool: line 4992: cd: no/lib: No such file or
> directory
> libtool: link: cannot determine absolute directory name of `no/lib'
> ]]]
> 
> [[[
> Fixes build failure when configured with '--without-zlib'.
> 
> * build/ac-macros/zlib.m4
>   (SVN_LIB_Z): Configure error-outs if executed with '--without-zlib'
>    or '--with-zlib=no' options.
> 
> Patch by: Alexander Thomas <al...@collab.net>
> ]]]
> 
> 
> -Alexander Thomas(AT)

> Index: build/ac-macros/zlib.m4
> ===================================================================
> --- build/ac-macros/zlib.m4	(revision 1174526)
> +++ build/ac-macros/zlib.m4	(working copy)
> @@ -32,6 +32,8 @@ AC_DEFUN(SVN_LIB_Z,
>    [
>      if test "$withval" = "yes" ; then
>        AC_MSG_ERROR([--with-zlib requires an argument.])
> +    elif test "$withval" = "no" ; then
> +      AC_MSG_ERROR([cannot compile without zlib.])
>      else
>        AC_MSG_NOTICE([zlib library configuration])
>        zlib_prefix=$withval