You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-user@db.apache.org by David Van Couvering <Da...@Sun.COM> on 2006/05/23 01:24:14 UTC

In-memory store implementation available for contribution (was: Re: derby-user Digest 20 May 2006 17:44:25 -0000 Issue 322)

Great!  I'm not sure what you mean by "a copy of the jar file" but we'd 
of course like to see the source, not just the binaries.

The student must explicitly indicate that he is handing over the code to 
the ASF. The normal way this is done is to create a JIRA item (our bug 
tracking system) and then put the changes he's made as an attachment to 
this JIRA item, indicating he is granting the code to the ASF.  I'd be 
happy to help guide the student through this process.  Better yet, we 
should have one of our store experts work with the student to look at 
getting his code in.  Any volunteers?

David

Darcy Benoit wrote:
> 
> I had a student implement an in-memory version of Derby for his honours 
> thesis. I am under the impression that the code is just about ready to 
> submit to the code tree. I can get you a copy of the jar file with the 
> in-memory implementation if you want, but I am not sure that it has pass 
> the derby-all testing.
> 
> darcy
> 
> 
> On Sat, 20 May 2006 14:44:25 -0300, 
> <de...@db.apache.org> wrote:
> 
>> Date:     Thu, 18 May 2006 10:40:42 -0700   
>> From:     David Van Couvering <Da...@Sun.COM>   
>> Subject:     Re: High throughput, min durability - tuning   
>> To:     derby-dev@db.apache.org   
>> Cc:     derby-user@db.apache.org, ashwinjay <as...@rediffmail.com>   
>>
>> Well, I have a couple of thoughts:
>>
>>
>> - Depending upon your OS, often the /tmp directory is actually mapped 
>> to memory, not disk.  You might
>> try putting your database in /tmp
>>
>>
>> - There has been a proposal and I think some work on implementing an 
>> in-memory implementation of the
>> store interface.  I would highly recommend you think about building 
>> this yourself.  There are experts
>> on the team who would be more than glad to guide you in this effort.  
>> If nothing else you would learn
>> some of the itnernals really well which could only help you in your 
>> efforts to tune the system.
>>
>>
>> David
>>
>>
> 
> 
> 
> --Dr. Darcy Benoit
> http://cs.acadiau.ca/~dbenoit/

Re: In-memory store implementation available for contribution

Posted by Andrew McIntyre <mc...@gmail.com>.
On 5/22/06, David Van Couvering <Da...@sun.com> wrote:
> OK, thanks, I thought this was a separate effort than the one already
> contributed.
>
> If we don't get the CLA, are we able to take what he's contributed and
> run with it?  Or do we need to start from scratch?

How motivated are you to chase down the legal issues? :-)

... non-lawyer hack opinion on legal matters follows ...

I'd say that since it was definitely submitted for inclusion with the
work, as described in section 5 of the license, and that the author
clearly labelled the source for the new files as licensed under the
ASL v2.0, and that the author chose the 'grant license to ASF' option
in JIRA when contributing the files, it *might* be possible to prepare
a derivative work based on the original contribution as described in
section 2 of the Apache license.

BUT, I am not a lawyer. By my reading of the license and ICLA, it
depends on whether or not you believe the original author holds the
copyright to the contributed work, and was authorized to grant the ASF
the license as described in section 5 of the ASL without also having
sections 2, 4, and 5 of an executed ICLA in effect, and thus that the
terms of sections 2 and/or 5 of the ASL are sufficient to cover any
derivative works based on the original contribution without an ICLA in
effect. It would appear that if the person who originally submitted
the contribution holds the copyright to the contribution, and
submitted it for inclusion to the work (Derby) as per section 5 of the
ASL, then sections 2 and 5 of the ASL hold, and derivative works may
be made. I think this is a reasonable belief, considering that we have
heard that the original contributor (Stephen Fitch) created the work
in question while studying with Mr. Benoit at Acadia U..

... end worthless opinion on legal issues ...

But I AM NOT A LAWYER, nor do I claim to be one on TV or otherwise. So
what I believe isn't likely to hold up in court. Were you hoping for a
simple answer? There probably isn't one. This falls directly into a
grey area with regards to contributions apparently licensed under the
ASL by people who have not executed an ICLA, or whose work is covered
by a CCLA, and I suggest asking legal-discuss if you plan on pursuing
this further, either by yourself or with a student via SoC or
otherwise.

With my release manager hat on, though, I can say that I would not be
willing to put forth a release with a contribution whose legality is
in question. But, if you do get a resolution on the issue, please let
me know. :-)

You could ask Mr. Benoit for help in tracking down the original author
and getting him to sign an ICLA. That may not be possible at this
point, since the original author was a student at Acadia U. and may no
longer be there, but it might be worth the effort.

andrew

references:
(ASL)  http://www.apache.org/licenses/LICENSE-2.0
(ICLA) http://www.apache.org/licenses/icla.txt
(CCLA) http://www.apache.org/licenses/cla-corporate.txt

Re: In-memory store implementation available for contribution

Posted by Daniel John Debrunner <dj...@apache.org>.
David Van Couvering wrote:

> OK, thanks, I thought this was a separate effort than the one already
> contributed.
> 
> If we don't get the CLA, are we able to take what he's contributed and
> run with it? 

I don't think so.

Dan.


Re: In-memory store implementation available for contribution

Posted by "Jean T. Anderson" <jt...@bristowhill.com>.
Jean T. Anderson wrote:
> David Van Couvering wrote:
> 
>>OK, thanks, I thought this was a separate effort than the one already
>>contributed.
>>
>>If we don't get the CLA, are we able to take what he's contributed and
>>run with it?  Or do we need to start from scratch?
> 
> 
> There are 6 new files in the patch for DERBY-646, which makes a
> significant contribution, in my opinion, so that iCLA would be needed.

oops -- never apply a patch quickly then do a quick 'svn status'. On the
revert, I discovered I missed all the files in a new "memory" subdirectory.

This is bigger than just the 6 files I looked at, so there's no doubt in
my mind that this requires an iCLA.

Of course, anyone who has actually looked at the code and built it
should feel free to chime in. But I'll now stop adding noise to the list :-)

 -jean



Re: In-memory store implementation available for contribution

Posted by David Van Couvering <Da...@Sun.COM>.
ugh.  And that's all I have to say about that.  IANAL nor do I intend to 
ever be one.

I agree this contribution is problematic because (a) it has the 1984 
copyright and (b) we can't locate the original contributor.

I think the best approach would be to find the contributor.  Since the 
professor just posted to derby-user, I will contact her directly and say 
we need to reach Stephen otherwise we can't use his potentially 
beneficial work.

David

Jean T. Anderson wrote:
> David Van Couvering wrote:
>> OK, thanks, I thought this was a separate effort than the one already
>> contributed.
>>
>> If we don't get the CLA, are we able to take what he's contributed and
>> run with it?  Or do we need to start from scratch?
> 
> There are 6 new files in the patch for DERBY-646, which makes a
> significant contribution, in my opinion, so that iCLA would be needed.
> (My apologies if this info already got repeated in another thread).
> 
> One of the questions I would have for Stephen, if Professor Benoit can
> locate him, is why 4 of the files have "Copyright 1998, 2004" and two
> others have "Copyright 2004". Does Stephen own that earlier work from
> 1998 and has the rights to grant license to the ASF? --At the very
> least, we would need an on-list conversation with Stephen to clear the ip.
> 
> If Stephen can't be located, there's always the option of pointing to
> DERBY-646 on the Derby Wiki so others can find his work and compile it
> in. Not ideal, I realize.
> 
>  -jean
> 
> 

Re: In-memory store implementation available for contribution

Posted by "Jean T. Anderson" <jt...@bristowhill.com>.
Jean T. Anderson wrote:
> David Van Couvering wrote:
> 
>>OK, thanks, I thought this was a separate effort than the one already
>>contributed.
>>
>>If we don't get the CLA, are we able to take what he's contributed and
>>run with it?  Or do we need to start from scratch?
...
> One of the questions I would have for Stephen, if Professor Benoit can
> locate him, is why 4 of the files have "Copyright 1998, 2004" and two
> others have "Copyright 2004". Does Stephen own that earlier work from
> 1998 and has the rights to grant license to the ASF? --At the very
> least, we would need an on-list conversation with Stephen to clear the ip.

And actually, he posted the contribution to DERBY-646 in October 2005,
so it's possible he meant the copyright to be 2005 and not 2004 -- and
it's possible he didn't pay close attention to the dates in the
copyright. At any rate, we would need to have that on-list conversation
with Stephen to clarify any fine points.

 -jean



Re: In-memory store implementation available for contribution

Posted by "Jean T. Anderson" <jt...@bristowhill.com>.
David Van Couvering wrote:
> OK, thanks, I thought this was a separate effort than the one already
> contributed.
> 
> If we don't get the CLA, are we able to take what he's contributed and
> run with it?  Or do we need to start from scratch?

There are 6 new files in the patch for DERBY-646, which makes a
significant contribution, in my opinion, so that iCLA would be needed.
(My apologies if this info already got repeated in another thread).

One of the questions I would have for Stephen, if Professor Benoit can
locate him, is why 4 of the files have "Copyright 1998, 2004" and two
others have "Copyright 2004". Does Stephen own that earlier work from
1998 and has the rights to grant license to the ASF? --At the very
least, we would need an on-list conversation with Stephen to clear the ip.

If Stephen can't be located, there's always the option of pointing to
DERBY-646 on the Derby Wiki so others can find his work and compile it
in. Not ideal, I realize.

 -jean



Re: In-memory store implementation available for contribution

Posted by David Van Couvering <Da...@Sun.COM>.
OK, thanks, I thought this was a separate effort than the one already 
contributed.

If we don't get the CLA, are we able to take what he's contributed and 
run with it?  Or do we need to start from scratch?

David

Andrew McIntyre wrote:
> On 5/22/06, David Van Couvering <Da...@sun.com> wrote:
>> Great!  I'm not sure what you mean by "a copy of the jar file" but we'd
>> of course like to see the source, not just the binaries.
>>
>> The student must explicitly indicate that he is handing over the code to
>> the ASF. The normal way this is done is to create a JIRA item (our bug
>> tracking system) and then put the changes he's made as an attachment to
>> this JIRA item, indicating he is granting the code to the ASF.  I'd be
>> happy to help guide the student through this process.  Better yet, we
>> should have one of our store experts work with the student to look at
>> getting his code in.  Any volunteers?
> 
> I believe we already have the source:
> 
> http://issues.apache.org/jira/browse/DERBY-646
> 
> Attached as 'svn.diff'.
> 
> There were some problems as far as getting this committed, though. Dan
> thought this crossed the threshold of requiring the contributor to
> submit a CLA (although the author did choose the 'grant license to
> ASF'  option in JIRA), and there were other issues: lack of comments
> and lack of tests.
> 
> I suspect the original author may not be interested or have time to
> finish the patch beyond what's already been contributed. Some other
> motivated person could pick up this contribution and take it the rest
> of the way, though.
> 
> andrew

Re: In-memory store implementation available for contribution (was: Re: derby-user Digest 20 May 2006 17:44:25 -0000 Issue 322)

Posted by Andrew McIntyre <mc...@gmail.com>.
On 5/22/06, David Van Couvering <Da...@sun.com> wrote:
> Great!  I'm not sure what you mean by "a copy of the jar file" but we'd
> of course like to see the source, not just the binaries.
>
> The student must explicitly indicate that he is handing over the code to
> the ASF. The normal way this is done is to create a JIRA item (our bug
> tracking system) and then put the changes he's made as an attachment to
> this JIRA item, indicating he is granting the code to the ASF.  I'd be
> happy to help guide the student through this process.  Better yet, we
> should have one of our store experts work with the student to look at
> getting his code in.  Any volunteers?

I believe we already have the source:

http://issues.apache.org/jira/browse/DERBY-646

Attached as 'svn.diff'.

There were some problems as far as getting this committed, though. Dan
thought this crossed the threshold of requiring the contributor to
submit a CLA (although the author did choose the 'grant license to
ASF'  option in JIRA), and there were other issues: lack of comments
and lack of tests.

I suspect the original author may not be interested or have time to
finish the patch beyond what's already been contributed. Some other
motivated person could pick up this contribution and take it the rest
of the way, though.

andrew

Re: In-memory store implementation available for contribution (was: Re: derby-user Digest 20 May 2006 17:44:25 -0000 Issue 322)

Posted by Andrew McIntyre <mc...@gmail.com>.
On 5/22/06, David Van Couvering <Da...@sun.com> wrote:
> Great!  I'm not sure what you mean by "a copy of the jar file" but we'd
> of course like to see the source, not just the binaries.
>
> The student must explicitly indicate that he is handing over the code to
> the ASF. The normal way this is done is to create a JIRA item (our bug
> tracking system) and then put the changes he's made as an attachment to
> this JIRA item, indicating he is granting the code to the ASF.  I'd be
> happy to help guide the student through this process.  Better yet, we
> should have one of our store experts work with the student to look at
> getting his code in.  Any volunteers?

I believe we already have the source:

http://issues.apache.org/jira/browse/DERBY-646

Attached as 'svn.diff'.

There were some problems as far as getting this committed, though. Dan
thought this crossed the threshold of requiring the contributor to
submit a CLA (although the author did choose the 'grant license to
ASF'  option in JIRA), and there were other issues: lack of comments
and lack of tests.

I suspect the original author may not be interested or have time to
finish the patch beyond what's already been contributed. Some other
motivated person could pick up this contribution and take it the rest
of the way, though.

andrew