You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2017/12/05 05:35:00 UTC
[jira] [Commented] (SOLR-11336) DocBasedVersionConstraintsProcessor
should be more extensible and support multiple version fields
[ https://issues.apache.org/jira/browse/SOLR-11336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278043#comment-16278043 ]
David Smiley commented on SOLR-11336:
-------------------------------------
Overall +1 thus far.
The docs for isVersionNewEnough was modified to say it returns "the solr version" instead of "true". But no, it's true/false. Perhaps you were toying with some refactoring to this method and backed out.
I'm not sure what methods should be protected vs private but I can tell when you were deliberate about it, and those places make sense to me.
Although likely out of scope, FYI increasingly URPs are allowing a parameter based configuration and then auto-register it such that you needn't have to touch your configuration to use it. See TemplateUpdateProcessorFactory and UUIDUpdateProcessorFactory for what I mean.
> DocBasedVersionConstraintsProcessor should be more extensible and support multiple version fields
> -------------------------------------------------------------------------------------------------
>
> Key: SOLR-11336
> URL: https://issues.apache.org/jira/browse/SOLR-11336
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: master (8.0)
> Reporter: Michael Braun
> Priority: Minor
> Attachments: SOLR-11336.patch, SOLR-11336.patch
>
>
> DocBasedVersionConstraintsProcessor supports allowing document updates only if the new version is greater than the old. However, if any behavior wants to be extended / changed in minor ways, the entire class will need to be copied and slightly modified rather than extending and changing the method in question.
> It would be nice if DocBasedVersionConstraintsProcessor stood on its own as a non-private class. In addition, certain methods (such as pieces of isVersionNewEnough) should be broken out into separate methods so they can be extended such that someone can extend the processor class and override what it means for a new version to be accepted (allowing equal versions through? What if new is a lower not greater number?).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org