You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "knight42 (via GitHub)" <gi...@apache.org> on 2023/03/25 07:44:54 UTC
[GitHub] [incubator-opendal] knight42 opened a new pull request, #1759: feat(oli): implement `oli cat`
knight42 opened a new pull request, #1759:
URL: https://github.com/apache/incubator-opendal/pull/1759
Ref #422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #1759: feat(oli): implement `oli cat`
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #1759:
URL: https://github.com/apache/incubator-opendal/pull/1759#discussion_r1148340229
##########
bin/oli/src/commands/cat.rs:
##########
@@ -0,0 +1,48 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use std::io::stdout;
+use std::path::PathBuf;
+
+use anyhow::{anyhow, Result};
+use clap::{Arg, ArgMatches, Command};
+use futures::io::{self, AllowStdIo};
+
+use crate::config::Config;
+
+pub async fn main(args: &ArgMatches) -> Result<()> {
+ let config_path = args
+ .get_one::<PathBuf>("config")
+ .ok_or_else(|| anyhow!("missing config path"))?;
+ let cfg = Config::load(config_path)?;
+
+ let target = args
+ .get_one::<String>("target")
+ .ok_or_else(|| anyhow!("missing target"))?;
+ let (op, path) = cfg.parse_location(target)?;
+
+ let reader = op.reader(path).await?;
+ let mut out = AllowStdIo::new(stdout());
+ io::copy(reader, &mut out).await?;
Review Comment:
opendal's Reader implemetns `tokio::AsyncRead` too :laughing:
##########
bin/oli/src/commands/cat.rs:
##########
@@ -0,0 +1,48 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use std::io::stdout;
+use std::path::PathBuf;
+
+use anyhow::{anyhow, Result};
+use clap::{Arg, ArgMatches, Command};
+use futures::io::{self, AllowStdIo};
+
+use crate::config::Config;
+
+pub async fn main(args: &ArgMatches) -> Result<()> {
+ let config_path = args
+ .get_one::<PathBuf>("config")
+ .ok_or_else(|| anyhow!("missing config path"))?;
+ let cfg = Config::load(config_path)?;
+
+ let target = args
+ .get_one::<String>("target")
+ .ok_or_else(|| anyhow!("missing target"))?;
+ let (op, path) = cfg.parse_location(target)?;
+
+ let reader = op.reader(path).await?;
+ let mut out = AllowStdIo::new(stdout());
+ io::copy(reader, &mut out).await?;
Review Comment:
opendal's Reader implements `tokio::AsyncRead` too :laughing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] knight42 commented on a diff in pull request #1759: feat(oli): implement `oli cat`
Posted by "knight42 (via GitHub)" <gi...@apache.org>.
knight42 commented on code in PR #1759:
URL: https://github.com/apache/incubator-opendal/pull/1759#discussion_r1148340059
##########
bin/oli/src/commands/cat.rs:
##########
@@ -0,0 +1,48 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use std::io::stdout;
+use std::path::PathBuf;
+
+use anyhow::{anyhow, Result};
+use clap::{Arg, ArgMatches, Command};
+use futures::io::{self, AllowStdIo};
+
+use crate::config::Config;
+
+pub async fn main(args: &ArgMatches) -> Result<()> {
+ let config_path = args
+ .get_one::<PathBuf>("config")
+ .ok_or_else(|| anyhow!("missing config path"))?;
+ let cfg = Config::load(config_path)?;
+
+ let target = args
+ .get_one::<String>("target")
+ .ok_or_else(|| anyhow!("missing target"))?;
+ let (op, path) = cfg.parse_location(target)?;
+
+ let reader = op.reader(path).await?;
+ let mut out = AllowStdIo::new(stdout());
+ io::copy(reader, &mut out).await?;
Review Comment:
it seems a little tricky, if we were going to use `futures::io::copy`, the writer needs to implement `futures::AsyncWrite`, while `tokio::io::Stdout` only implments `tokio::io::AsyncWrite`. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] messense commented on a diff in pull request #1759: feat(oli): implement `oli cat`
Posted by "messense (via GitHub)" <gi...@apache.org>.
messense commented on code in PR #1759:
URL: https://github.com/apache/incubator-opendal/pull/1759#discussion_r1148340448
##########
bin/oli/src/commands/cat.rs:
##########
@@ -0,0 +1,48 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use std::io::stdout;
+use std::path::PathBuf;
+
+use anyhow::{anyhow, Result};
+use clap::{Arg, ArgMatches, Command};
+use futures::io::{self, AllowStdIo};
+
+use crate::config::Config;
+
+pub async fn main(args: &ArgMatches) -> Result<()> {
+ let config_path = args
+ .get_one::<PathBuf>("config")
+ .ok_or_else(|| anyhow!("missing config path"))?;
+ let cfg = Config::load(config_path)?;
+
+ let target = args
+ .get_one::<String>("target")
+ .ok_or_else(|| anyhow!("missing target"))?;
+ let (op, path) = cfg.parse_location(target)?;
+
+ let reader = op.reader(path).await?;
+ let mut out = AllowStdIo::new(stdout());
+ io::copy(reader, &mut out).await?;
Review Comment:
> if we were going to use `futures::io::copy`
How about [`tokio::io::copy`](https://docs.rs/tokio/latest/tokio/io/fn.copy.html)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] knight42 commented on a diff in pull request #1759: feat(oli): implement `oli cat`
Posted by "knight42 (via GitHub)" <gi...@apache.org>.
knight42 commented on code in PR #1759:
URL: https://github.com/apache/incubator-opendal/pull/1759#discussion_r1148340994
##########
bin/oli/src/commands/cat.rs:
##########
@@ -0,0 +1,48 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use std::io::stdout;
+use std::path::PathBuf;
+
+use anyhow::{anyhow, Result};
+use clap::{Arg, ArgMatches, Command};
+use futures::io::{self, AllowStdIo};
+
+use crate::config::Config;
+
+pub async fn main(args: &ArgMatches) -> Result<()> {
+ let config_path = args
+ .get_one::<PathBuf>("config")
+ .ok_or_else(|| anyhow!("missing config path"))?;
+ let cfg = Config::load(config_path)?;
+
+ let target = args
+ .get_one::<String>("target")
+ .ok_or_else(|| anyhow!("missing target"))?;
+ let (op, path) = cfg.parse_location(target)?;
+
+ let reader = op.reader(path).await?;
+ let mut out = AllowStdIo::new(stdout());
+ io::copy(reader, &mut out).await?;
Review Comment:
Thanks for your suggestion, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #1759: feat(oli): implement `oli cat`
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #1759:
URL: https://github.com/apache/incubator-opendal/pull/1759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] knight42 commented on a diff in pull request #1759: feat(oli): implement `oli cat`
Posted by "knight42 (via GitHub)" <gi...@apache.org>.
knight42 commented on code in PR #1759:
URL: https://github.com/apache/incubator-opendal/pull/1759#discussion_r1148324009
##########
bin/oli/src/commands/cat.rs:
##########
@@ -0,0 +1,48 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use std::io::stdout;
+use std::path::PathBuf;
+
+use anyhow::{anyhow, Result};
+use clap::{Arg, ArgMatches, Command};
+use futures::io::{self, AllowStdIo};
+
+use crate::config::Config;
+
+pub async fn main(args: &ArgMatches) -> Result<()> {
+ let config_path = args
+ .get_one::<PathBuf>("config")
+ .ok_or_else(|| anyhow!("missing config path"))?;
+ let cfg = Config::load(config_path)?;
+
+ let target = args
+ .get_one::<String>("target")
+ .ok_or_else(|| anyhow!("missing target"))?;
+ let (op, path) = cfg.parse_location(target)?;
+
+ let reader = op.reader(path).await?;
+ let mut out = AllowStdIo::new(stdout());
+ io::copy(reader, &mut out).await?;
Review Comment:
I am new to async rust, and not sure if this is the right way to copy data to stdout. If there is a better way, I am happy to update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #1759: feat(oli): implement `oli cat`
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #1759:
URL: https://github.com/apache/incubator-opendal/pull/1759#discussion_r1148329531
##########
bin/oli/src/commands/cat.rs:
##########
@@ -0,0 +1,48 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use std::io::stdout;
+use std::path::PathBuf;
+
+use anyhow::{anyhow, Result};
+use clap::{Arg, ArgMatches, Command};
+use futures::io::{self, AllowStdIo};
+
+use crate::config::Config;
+
+pub async fn main(args: &ArgMatches) -> Result<()> {
+ let config_path = args
+ .get_one::<PathBuf>("config")
+ .ok_or_else(|| anyhow!("missing config path"))?;
+ let cfg = Config::load(config_path)?;
+
+ let target = args
+ .get_one::<String>("target")
+ .ok_or_else(|| anyhow!("missing target"))?;
+ let (op, path) = cfg.parse_location(target)?;
+
+ let reader = op.reader(path).await?;
+ let mut out = AllowStdIo::new(stdout());
+ io::copy(reader, &mut out).await?;
Review Comment:
We can use https://docs.rs/tokio/latest/tokio/io/fn.stdout.html#
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] knight42 commented on a diff in pull request #1759: feat(oli): implement `oli cat`
Posted by "knight42 (via GitHub)" <gi...@apache.org>.
knight42 commented on code in PR #1759:
URL: https://github.com/apache/incubator-opendal/pull/1759#discussion_r1148340439
##########
bin/oli/src/commands/cat.rs:
##########
@@ -0,0 +1,48 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use std::io::stdout;
+use std::path::PathBuf;
+
+use anyhow::{anyhow, Result};
+use clap::{Arg, ArgMatches, Command};
+use futures::io::{self, AllowStdIo};
+
+use crate::config::Config;
+
+pub async fn main(args: &ArgMatches) -> Result<()> {
+ let config_path = args
+ .get_one::<PathBuf>("config")
+ .ok_or_else(|| anyhow!("missing config path"))?;
+ let cfg = Config::load(config_path)?;
+
+ let target = args
+ .get_one::<String>("target")
+ .ok_or_else(|| anyhow!("missing target"))?;
+ let (op, path) = cfg.parse_location(target)?;
+
+ let reader = op.reader(path).await?;
+ let mut out = AllowStdIo::new(stdout());
+ io::copy(reader, &mut out).await?;
Review Comment:
Ohh so I should use `tokio::io::copy`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org