You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/04/17 22:06:14 UTC
[jira] Created: (CASSANDRA-88) clean up CassandraServer and
StorageProxy
clean up CassandraServer and StorageProxy
-----------------------------------------
Key: CASSANDRA-88
URL: https://issues.apache.org/jira/browse/CASSANDRA-88
Project: Cassandra
Issue Type: Improvement
Reporter: Jonathan Ellis
there is a ton of duplicate code here that makes it difficult to improve the thrift interface
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-88) clean up CassandraServer and
StorageProxy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700350#action_12700350 ]
Jonathan Ellis commented on CASSANDRA-88:
-----------------------------------------
(01 and 03 were done entirely automatically w/ the IDE.)
> clean up CassandraServer and StorageProxy
> -----------------------------------------
>
> Key: CASSANDRA-88
> URL: https://issues.apache.org/jira/browse/CASSANDRA-88
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-CASSANDRA-88-rename-get_cf-readColumnFamily-ReadMe.txt, 0002-clean-up-ReadCommand-it-s-basically-a-struct-so-use-p.txt, 0003-rename-ReadResponseMessage-ReadResponse.txt, 0004-refactor-read-path-first-we-make-readColumnFamily-acc.txt
>
>
> there is a ton of duplicate code here that makes it difficult to improve the thrift interface
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-88) clean up CassandraServer and
StorageProxy
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-88:
--------------------------------
Attachment: 0001-update-cql-classes-for-StorageProxy.readProtocol-int.txt
> clean up CassandraServer and StorageProxy
> -----------------------------------------
>
> Key: CASSANDRA-88
> URL: https://issues.apache.org/jira/browse/CASSANDRA-88
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-CASSANDRA-88-rename-get_cf-readColumnFamily-ReadMe.txt, 0001-update-cql-classes-for-StorageProxy.readProtocol-int.txt, 0002-clean-up-ReadCommand-it-s-basically-a-struct-so-use-p.txt, 0002-v2.patch, 0002-v3.patch, 0003-rename-ReadResponseMessage-ReadResponse.txt, 0004-refactor-read-path-first-we-make-readColumnFamily-acc.txt, 0004-v3.patch
>
>
> there is a ton of duplicate code here that makes it difficult to improve the thrift interface
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-88) clean up CassandraServer and
StorageProxy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-88:
------------------------------------
Attachment: 0004-v3.patch
fix for countfilter test in ReadCommand.getRow
> clean up CassandraServer and StorageProxy
> -----------------------------------------
>
> Key: CASSANDRA-88
> URL: https://issues.apache.org/jira/browse/CASSANDRA-88
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-CASSANDRA-88-rename-get_cf-readColumnFamily-ReadMe.txt, 0002-clean-up-ReadCommand-it-s-basically-a-struct-so-use-p.txt, 0002-v2.patch, 0002-v3.patch, 0003-rename-ReadResponseMessage-ReadResponse.txt, 0004-refactor-read-path-first-we-make-readColumnFamily-acc.txt, 0004-v3.patch
>
>
> there is a ton of duplicate code here that makes it difficult to improve the thrift interface
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-88) clean up CassandraServer and
StorageProxy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700348#action_12700348 ]
Jonathan Ellis commented on CASSANDRA-88:
-----------------------------------------
04
refactor read path: first we make readColumnFamily accept a ReadCommand, and use that to clean out duplicate code in CassandraServer. Then we clean up the duplicate versions ofthe read methods in StorageService by making them ReadCommand-based, too. [not touching multiget code for now.]
03
rename ReadResponseMessage -> ReadResponse
02
clean up ReadCommand; it's basically a struct so use public final fields
01
CASSANDRA-88 rename get_cf -> readColumnFamily; ReadMessage -> ReadCommand
[Message message = ReadMessage.readMessage(readMessage) is just plain confusing]
> clean up CassandraServer and StorageProxy
> -----------------------------------------
>
> Key: CASSANDRA-88
> URL: https://issues.apache.org/jira/browse/CASSANDRA-88
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-CASSANDRA-88-rename-get_cf-readColumnFamily-ReadMe.txt, 0002-clean-up-ReadCommand-it-s-basically-a-struct-so-use-p.txt, 0003-rename-ReadResponseMessage-ReadResponse.txt, 0004-refactor-read-path-first-we-make-readColumnFamily-acc.txt
>
>
> there is a ton of duplicate code here that makes it difficult to improve the thrift interface
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-88) clean up CassandraServer and
StorageProxy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-88:
------------------------------------
Attachment: 0002-v2.patch
0002 that preserves better toString
> clean up CassandraServer and StorageProxy
> -----------------------------------------
>
> Key: CASSANDRA-88
> URL: https://issues.apache.org/jira/browse/CASSANDRA-88
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-CASSANDRA-88-rename-get_cf-readColumnFamily-ReadMe.txt, 0002-clean-up-ReadCommand-it-s-basically-a-struct-so-use-p.txt, 0002-v2.patch, 0003-rename-ReadResponseMessage-ReadResponse.txt, 0004-refactor-read-path-first-we-make-readColumnFamily-acc.txt
>
>
> there is a ton of duplicate code here that makes it difficult to improve the thrift interface
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-88) clean up CassandraServer and
StorageProxy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-88:
------------------------------------
Attachment: 0004-refactor-read-path-first-we-make-readColumnFamily-acc.txt
0003-rename-ReadResponseMessage-ReadResponse.txt
0002-clean-up-ReadCommand-it-s-basically-a-struct-so-use-p.txt
0001-CASSANDRA-88-rename-get_cf-readColumnFamily-ReadMe.txt
> clean up CassandraServer and StorageProxy
> -----------------------------------------
>
> Key: CASSANDRA-88
> URL: https://issues.apache.org/jira/browse/CASSANDRA-88
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-CASSANDRA-88-rename-get_cf-readColumnFamily-ReadMe.txt, 0002-clean-up-ReadCommand-it-s-basically-a-struct-so-use-p.txt, 0003-rename-ReadResponseMessage-ReadResponse.txt, 0004-refactor-read-path-first-we-make-readColumnFamily-acc.txt
>
>
> there is a ton of duplicate code here that makes it difficult to improve the thrift interface
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-88) clean up CassandraServer and
StorageProxy
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700888#action_12700888 ]
Eric Evans commented on CASSANDRA-88:
-------------------------------------
This looks pretty good to me, with the exception of a few classes in org.apache.cassandra.cql which didn't get updated. +1 provided that 0001-update-cql-classes-for-StorageProxy.readProtocol-int.txt (or something comparable) is applied.
(Sorry about the poor naming of the patch I attached.)
> clean up CassandraServer and StorageProxy
> -----------------------------------------
>
> Key: CASSANDRA-88
> URL: https://issues.apache.org/jira/browse/CASSANDRA-88
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-CASSANDRA-88-rename-get_cf-readColumnFamily-ReadMe.txt, 0001-update-cql-classes-for-StorageProxy.readProtocol-int.txt, 0002-clean-up-ReadCommand-it-s-basically-a-struct-so-use-p.txt, 0002-v2.patch, 0002-v3.patch, 0003-rename-ReadResponseMessage-ReadResponse.txt, 0004-refactor-read-path-first-we-make-readColumnFamily-acc.txt, 0004-v3.patch
>
>
> there is a ton of duplicate code here that makes it difficult to improve the thrift interface
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-88) clean up CassandraServer and
StorageProxy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-88:
---------------------------------------
Assignee: Jonathan Ellis
> clean up CassandraServer and StorageProxy
> -----------------------------------------
>
> Key: CASSANDRA-88
> URL: https://issues.apache.org/jira/browse/CASSANDRA-88
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
>
> there is a ton of duplicate code here that makes it difficult to improve the thrift interface
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-88) clean up CassandraServer and
StorageProxy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700890#action_12700890 ]
Jonathan Ellis commented on CASSANDRA-88:
-----------------------------------------
oops, thanks for catching that. (every once in a while relying on intellij instead of ant bites me. :)
> clean up CassandraServer and StorageProxy
> -----------------------------------------
>
> Key: CASSANDRA-88
> URL: https://issues.apache.org/jira/browse/CASSANDRA-88
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-CASSANDRA-88-rename-get_cf-readColumnFamily-ReadMe.txt, 0001-update-cql-classes-for-StorageProxy.readProtocol-int.txt, 0002-clean-up-ReadCommand-it-s-basically-a-struct-so-use-p.txt, 0002-v2.patch, 0002-v3.patch, 0003-rename-ReadResponseMessage-ReadResponse.txt, 0004-refactor-read-path-first-we-make-readColumnFamily-acc.txt, 0004-v3.patch
>
>
> there is a ton of duplicate code here that makes it difficult to improve the thrift interface
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-88) clean up CassandraServer and
StorageProxy
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-88:
------------------------------------
Attachment: 0002-v3.patch
fix deserialize regression
> clean up CassandraServer and StorageProxy
> -----------------------------------------
>
> Key: CASSANDRA-88
> URL: https://issues.apache.org/jira/browse/CASSANDRA-88
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-CASSANDRA-88-rename-get_cf-readColumnFamily-ReadMe.txt, 0002-clean-up-ReadCommand-it-s-basically-a-struct-so-use-p.txt, 0002-v2.patch, 0002-v3.patch, 0003-rename-ReadResponseMessage-ReadResponse.txt, 0004-refactor-read-path-first-we-make-readColumnFamily-acc.txt
>
>
> there is a ton of duplicate code here that makes it difficult to improve the thrift interface
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.