You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/08/12 03:16:26 UTC
[GitHub] [incubator-mxnet] mseth10 opened a new pull request #20517: [v1.9.x] modify erfinv implementation based on scipy
mseth10 opened a new pull request #20517:
URL: https://github.com/apache/incubator-mxnet/pull/20517
## Description ##
Modify `erfinv` implementation based on SciPy's implementation. This fixes #20511
## Performance Analysis ##
Ran a simple python script twice
```
import mxnet as mx
import time
y = mx.nd.random.uniform(-1, 1, shape=(100,100))
start = time.time()
for i in range(1000000):
x= mx.ndarray.erfinv(y)
x.wait_to_read()
end = time.time()
print(end-start)
```
The earlier implementation took 51.19 secs and 53.06 secs.
With this PR changes, it takes 46.29 secs and 41.04 secs.
So, the new implementation is faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20517: [v1.9.x] modify erfinv implementation based on scipy
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20517:
URL: https://github.com/apache/incubator-mxnet/pull/20517#issuecomment-897315656
Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-gpu, miscellaneous, unix-cpu, unix-gpu, windows-gpu, edge, website, sanity, clang, windows-cpu, centos-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #20517: [v1.9.x] modify erfinv implementation based on scipy
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #20517:
URL: https://github.com/apache/incubator-mxnet/pull/20517#issuecomment-898761901
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20517: [v1.9.x] modify erfinv implementation based on scipy
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20517:
URL: https://github.com/apache/incubator-mxnet/pull/20517#issuecomment-898762807
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #20517: [v1.9.x] modify erfinv implementation based on scipy
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #20517:
URL: https://github.com/apache/incubator-mxnet/pull/20517#issuecomment-897321251
Is this file rightly placed in rat-excludes and tools/license_header.py ? @josephevans @leezu
https://github.com/apache/incubator-mxnet/blob/v1.9.x/rat-excludes#L124
https://github.com/apache/incubator-mxnet/blob/v1.9.x/tools/license_header.py#L108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 edited a comment on pull request #20517: [v1.9.x] modify erfinv implementation based on scipy
Posted by GitBox <gi...@apache.org>.
mseth10 edited a comment on pull request #20517:
URL: https://github.com/apache/incubator-mxnet/pull/20517#issuecomment-898761901
@mxnet-bot run ci [unix-gpu ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20517: [v1.9.x] modify erfinv implementation based on scipy
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20517:
URL: https://github.com/apache/incubator-mxnet/pull/20517#issuecomment-898763227
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20517: [v1.9.x] modify erfinv implementation based on scipy
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20517:
URL: https://github.com/apache/incubator-mxnet/pull/20517#issuecomment-898761930
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 edited a comment on pull request #20517: [v1.9.x] modify erfinv implementation based on scipy
Posted by GitBox <gi...@apache.org>.
mseth10 edited a comment on pull request #20517:
URL: https://github.com/apache/incubator-mxnet/pull/20517#issuecomment-898761901
@mxnet-bot run ci [ unix-gpu ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 merged pull request #20517: [v1.9.x] modify erfinv implementation based on scipy
Posted by GitBox <gi...@apache.org>.
mseth10 merged pull request #20517:
URL: https://github.com/apache/incubator-mxnet/pull/20517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on pull request #20517: [v1.9.x] modify erfinv implementation based on scipy
Posted by GitBox <gi...@apache.org>.
mseth10 commented on pull request #20517:
URL: https://github.com/apache/incubator-mxnet/pull/20517#issuecomment-898336948
@mxnet-bot run ci [unix-cpu ]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20517: [v1.9.x] modify erfinv implementation based on scipy
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20517:
URL: https://github.com/apache/incubator-mxnet/pull/20517#issuecomment-898337019
Jenkins CI successfully triggered : [unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org