You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/03/29 20:59:46 UTC

[GitHub] [incubator-iceberg] rdsr opened a new pull request #877: [Minor] Fix typo in TableMetadata comments

rdsr opened a new pull request #877: [Minor] Fix typo in TableMetadata comments
URL: https://github.com/apache/incubator-iceberg/pull/877
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [incubator-iceberg] jun-he commented on issue #877: [Minor] Fix typo in TableMetadata comments

Posted by GitBox <gi...@apache.org>.
jun-he commented on issue #877: [Minor] Fix typo in TableMetadata comments
URL: https://github.com/apache/incubator-iceberg/pull/877#issuecomment-605713446
 
 
   LGTM. Thanks for the fix.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #877: [Minor] Fix typo in TableMetadata comments

Posted by GitBox <gi...@apache.org>.
rdsr commented on a change in pull request #877: [Minor] Fix typo in TableMetadata comments
URL: https://github.com/apache/incubator-iceberg/pull/877#discussion_r399892316
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
 ##########
 @@ -426,7 +426,7 @@ public TableMetadata removeSnapshotsIf(Predicate<Snapshot> removeIf) {
         // copy the log entries that are still valid
         newSnapshotLog.add(logEntry);
       } else {
-        // any invalid entry causes the history before it to be removed. otherwise, there could be
 
 Review comment:
   oops, now that I read it the second time, the original one seems correct. Sorry my bad.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #877: [Minor] Fix typo in TableMetadata comments

Posted by GitBox <gi...@apache.org>.
rdsr commented on a change in pull request #877: [Minor] Fix typo in TableMetadata comments
URL: https://github.com/apache/incubator-iceberg/pull/877#discussion_r399892316
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
 ##########
 @@ -426,7 +426,7 @@ public TableMetadata removeSnapshotsIf(Predicate<Snapshot> removeIf) {
         // copy the log entries that are still valid
         newSnapshotLog.add(logEntry);
       } else {
-        // any invalid entry causes the history before it to be removed. otherwise, there could be
 
 Review comment:
   oops, now that I read it the again, the original one seems correct. Sorry my bad.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [incubator-iceberg] rdsr closed pull request #877: [Minor] Fix typo in TableMetadata comments

Posted by GitBox <gi...@apache.org>.
rdsr closed pull request #877: [Minor] Fix typo in TableMetadata comments
URL: https://github.com/apache/incubator-iceberg/pull/877
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org