You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by cafferata <gi...@git.apache.org> on 2017/10/25 13:56:47 UTC

[GitHub] incubator-predictionio-sdk-php pull request #24: Updated README.md

GitHub user cafferata opened a pull request:

    https://github.com/apache/incubator-predictionio-sdk-php/pull/24

    Updated README.md

    Following the Composer best practices and simplified the installation step(s).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cafferata/incubator-predictionio-sdk-php composer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-predictionio-sdk-php/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 4e6e25ac1771e083fe5a0f7b2736ea78509961b9
Author: Jeffrey Cafferata <je...@jcid.nl>
Date:   2017-10-25T13:56:04Z

    Following the Composer best practices and simplified the installation step(s).

----


---

[GitHub] incubator-predictionio-sdk-php issue #24: Updated README.md

Posted by cafferata <gi...@git.apache.org>.
Github user cafferata commented on the issue:

    https://github.com/apache/incubator-predictionio-sdk-php/pull/24
  
    I have processed both feedback points.


---

[GitHub] incubator-predictionio-sdk-php pull request #24: Updated README.md

Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on a diff in the pull request:

    https://github.com/apache/incubator-predictionio-sdk-php/pull/24#discussion_r147047179
  
    --- Diff: README.md ---
    @@ -42,23 +42,11 @@ By Composer
     
     The easiest way to install PredictionIO PHP client is to use [Composer](http://getcomposer.org/).
     
    -1. Add `predictionio/predictionio` as a dependency in your project's ``composer.json`` file:
    +1. `Predictionio` is available on [Packagist](https://packagist.org/packages/league/csv) and can be installed using [Composer](https://getcomposer.org/):
    --- End diff --
    
    Do you mean https://packagist.org/ instead for Packagist's link?
    
    The correct letter case for the module name should be `predictionio`. If indicating the project name, please use Apache PredictionIO.


---