You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Li Jing Qin (JIRA)" <ji...@apache.org> on 2008/11/25 04:34:44 UTC
[jira] Created: (HARMONY-6028) [classlib][luni] Unvalid IPv6
address is allowed in the SocketPermission
[classlib][luni] Unvalid IPv6 address is allowed in the SocketPermission
------------------------------------------------------------------------
Key: HARMONY-6028
URL: https://issues.apache.org/jira/browse/HARMONY-6028
Project: Harmony
Issue Type: Bug
Components: Classlib
Affects Versions: 5.0M8
Reporter: Li Jing Qin
Fix For: 5.0M8
According to the spec, the host which is allowed by the SocketPermission is specified as
host = (hostname | IPv4address | iPv6reference) [:portrange]
portrange = portnumber | -portnumber | portnumber-[portnumber]
ipv6reference = "[" IPv6address "]"
And the full uncompressed form of the IPv6 literal address is also allowed.
So such as [fe80::1], [FE80:0000:0000:0000:0000:0000:0000:0001]:80, FE80:0000:0000:0000:0000:0000:0000:0001, FE80:0000:0000:0000:0000:0000:0000:0001:80 is allowed, but FE80::1::80 is not allowed. The compressed form of ipv6 without "[" and "]" is not allowed.
We can find those bad address in the good arrays in our tests and the test pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6028) [classlib][luni] Unvalid IPv6
address is allowed in the SocketPermission
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Jing Qin updated HARMONY-6028:
---------------------------------
Attachment: patch_SocketPermission.diff
What I have changed as follows:
1. Add isIP6AddressInFullForm in the Inet6Util.java to test whether the ipv6 address is in full uncompressed form.
2. Change the getHostString in the SocketPermission according to the spec.
3. Refactor the parsePort method in the SocketPermission by using the host string just get.
4. Modify the test case in SocketPermissionTest to check the fix.
> [classlib][luni] Unvalid IPv6 address is allowed in the SocketPermission
> ------------------------------------------------------------------------
>
> Key: HARMONY-6028
> URL: https://issues.apache.org/jira/browse/HARMONY-6028
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M8
> Reporter: Li Jing Qin
> Fix For: 5.0M8
>
> Attachments: patch_SocketPermission.diff
>
>
> According to the spec, the host which is allowed by the SocketPermission is specified as
> host = (hostname | IPv4address | iPv6reference) [:portrange]
> portrange = portnumber | -portnumber | portnumber-[portnumber]
> ipv6reference = "[" IPv6address "]"
> And the full uncompressed form of the IPv6 literal address is also allowed.
> So such as [fe80::1], [FE80:0000:0000:0000:0000:0000:0000:0001]:80, FE80:0000:0000:0000:0000:0000:0000:0001, FE80:0000:0000:0000:0000:0000:0000:0001:80 is allowed, but FE80::1::80 is not allowed. The compressed form of ipv6 without "[" and "]" is not allowed.
> We can find those bad address in the good arrays in our tests and the test pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6028) [classlib][luni] Unvalid IPv6
address is allowed in the SocketPermission
Posted by "Jimmy, Jing Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy, Jing Lv resolved HARMONY-6028.
-------------------------------------
Resolution: Fixed
Fix Version/s: (was: 5.0M8)
5.0M9
The fix's fine, I've committed at r732272, please verify.
> [classlib][luni] Unvalid IPv6 address is allowed in the SocketPermission
> ------------------------------------------------------------------------
>
> Key: HARMONY-6028
> URL: https://issues.apache.org/jira/browse/HARMONY-6028
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M8
> Reporter: Li Jing Qin
> Assignee: Jimmy, Jing Lv
> Fix For: 5.0M9
>
> Attachments: patch_SocketPermission.diff
>
>
> According to the spec, the host which is allowed by the SocketPermission is specified as
> host = (hostname | IPv4address | iPv6reference) [:portrange]
> portrange = portnumber | -portnumber | portnumber-[portnumber]
> ipv6reference = "[" IPv6address "]"
> And the full uncompressed form of the IPv6 literal address is also allowed.
> So such as [fe80::1], [FE80:0000:0000:0000:0000:0000:0000:0001]:80, FE80:0000:0000:0000:0000:0000:0000:0001, FE80:0000:0000:0000:0000:0000:0000:0001:80 is allowed, but FE80::1::80 is not allowed. The compressed form of ipv6 without "[" and "]" is not allowed.
> We can find those bad address in the good arrays in our tests and the test pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6028) [classlib][luni] Unvalid IPv6
address is allowed in the SocketPermission
Posted by "Jimmy, Jing Lv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jimmy, Jing Lv reassigned HARMONY-6028:
---------------------------------------
Assignee: Jimmy, Jing Lv
> [classlib][luni] Unvalid IPv6 address is allowed in the SocketPermission
> ------------------------------------------------------------------------
>
> Key: HARMONY-6028
> URL: https://issues.apache.org/jira/browse/HARMONY-6028
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M8
> Reporter: Li Jing Qin
> Assignee: Jimmy, Jing Lv
> Fix For: 5.0M8
>
> Attachments: patch_SocketPermission.diff
>
>
> According to the spec, the host which is allowed by the SocketPermission is specified as
> host = (hostname | IPv4address | iPv6reference) [:portrange]
> portrange = portnumber | -portnumber | portnumber-[portnumber]
> ipv6reference = "[" IPv6address "]"
> And the full uncompressed form of the IPv6 literal address is also allowed.
> So such as [fe80::1], [FE80:0000:0000:0000:0000:0000:0000:0001]:80, FE80:0000:0000:0000:0000:0000:0000:0001, FE80:0000:0000:0000:0000:0000:0000:0001:80 is allowed, but FE80::1::80 is not allowed. The compressed form of ipv6 without "[" and "]" is not allowed.
> We can find those bad address in the good arrays in our tests and the test pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6028) [classlib][luni] Unvalid IPv6
address is allowed in the SocketPermission
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719482#action_12719482 ]
Li Jing Qin commented on HARMONY-6028:
--------------------------------------
Verified. Thanks Jimmy.
> [classlib][luni] Unvalid IPv6 address is allowed in the SocketPermission
> ------------------------------------------------------------------------
>
> Key: HARMONY-6028
> URL: https://issues.apache.org/jira/browse/HARMONY-6028
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M8
> Reporter: Li Jing Qin
> Assignee: Jimmy, Jing Lv
> Fix For: 5.0M9
>
> Attachments: patch_SocketPermission.diff
>
>
> According to the spec, the host which is allowed by the SocketPermission is specified as
> host = (hostname | IPv4address | iPv6reference) [:portrange]
> portrange = portnumber | -portnumber | portnumber-[portnumber]
> ipv6reference = "[" IPv6address "]"
> And the full uncompressed form of the IPv6 literal address is also allowed.
> So such as [fe80::1], [FE80:0000:0000:0000:0000:0000:0000:0001]:80, FE80:0000:0000:0000:0000:0000:0000:0001, FE80:0000:0000:0000:0000:0000:0000:0001:80 is allowed, but FE80::1::80 is not allowed. The compressed form of ipv6 without "[" and "]" is not allowed.
> We can find those bad address in the good arrays in our tests and the test pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.