You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sterlingann <gi...@git.apache.org> on 2016/11/04 17:45:46 UTC
[GitHub] cordova-ios pull request #273: Cb-12098 (iOS) update supportedinterfaceorien...
GitHub user sterlingann opened a pull request:
https://github.com/apache/cordova-ios/pull/273
Cb-12098 (iOS) update supportedinterfaceorientations return type
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Updates return type to UIInterfaceOrientationMask in iOS 9+
### What testing has been done on this change?
created test project, automated NPM test
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sterlingann/cordova-ios CB-12098
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #273
----
commit 63e14a1ed4b387552a9386176b3d02b23adeaf1e
Author: Sterling <st...@gmail.com>
Date: 2016-11-01T18:40:12Z
CB-12098 - Update supportedInterfaceOrientations return type
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #273: Cb-12098 (iOS) update supportedinterfaceorien...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/273#discussion_r87504252
--- Diff: CordovaLib/Classes/Public/CDVViewController.m ---
@@ -419,7 +419,13 @@ - (BOOL)shouldAutorotate
return YES;
}
-- (NSUInteger)supportedInterfaceOrientations
+// CB-12098
+#if __IPHONE_OS_VERSION_MAX_ALLOWED < 90000
+- (NSUInteger)supportedInterfaceOrientations
+#else
+- (UIInterfaceOrientationMask)supportedInterfaceOrientations
+#endif
+
--- End diff --
remove this empty line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #273: Cb-12098 (iOS) update supportedinterfaceorientations...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/273
@sterlingann please update the code according to recommendations in the code review, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #273: Cb-12098 (iOS) update supportedinterfaceorien...
Posted by sterlingann <gi...@git.apache.org>.
Github user sterlingann closed the pull request at:
https://github.com/apache/cordova-ios/pull/273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #273: Cb-12098 (iOS) update supportedinterfaceorien...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/273#discussion_r87504333
--- Diff: bin/templates/project/__PROJECT_NAME__/Classes/MainViewController.m ---
@@ -92,7 +92,13 @@ - (UIWebView*) newCordovaViewWithFrame:(CGRect)bounds
return[super newCordovaViewWithFrame:bounds];
}
-- (NSUInteger)supportedInterfaceOrientations
+// CB-12098
+#if __IPHONE_OS_VERSION_MAX_ALLOWED < 90000
+- (NSUInteger)supportedInterfaceOrientations
+#else
+- (UIInterfaceOrientationMask)supportedInterfaceOrientations
+#endif
+
--- End diff --
remove this empty line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #273: Cb-12098 (iOS) update supportedinterfaceorientations...
Posted by sterlingann <gi...@git.apache.org>.
Github user sterlingann commented on the issue:
https://github.com/apache/cordova-ios/pull/273
@shazron Lines are removed, sorry for the delay
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #273: Cb-12098 (iOS) update supportedinterfaceorientations...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/273
@sterlingann seems to be merge conflicts, you might need to rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org