You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/09/10 07:56:38 UTC
svn commit: r1760131 - in
/jmeter/trunk/src/core/org/apache/jmeter/report/processor:
ApdexSummaryConsumer.java StatisticsSummaryConsumer.java
Author: pmouawad
Date: Sat Sep 10 07:56:38 2016
New Revision: 1760131
URL: http://svn.apache.org/viewvc?rev=1760131&view=rev
Log:
Bug 60090 Report / Dashboard : Empty Transaction Controller should not count in metrics
Bugzilla Id: 60090
Modified:
jmeter/trunk/src/core/org/apache/jmeter/report/processor/ApdexSummaryConsumer.java
jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java
Modified: jmeter/trunk/src/core/org/apache/jmeter/report/processor/ApdexSummaryConsumer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/processor/ApdexSummaryConsumer.java?rev=1760131&r1=1760130&r2=1760131&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/processor/ApdexSummaryConsumer.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/processor/ApdexSummaryConsumer.java Sat Sep 10 07:56:38 2016
@@ -123,7 +123,7 @@ public class ApdexSummaryConsumer extend
overallData.incTotalCount();
// Process only succeeded samples
- if (sample.getSuccess()) {
+ if (sample.getSuccess() && !sample.isEmptyController()) {
long elapsedTime = sample.getElapsedTime();
// Increment the counters depending on the elapsed time.
Modified: jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java?rev=1760131&r1=1760130&r2=1760131&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/report/processor/StatisticsSummaryConsumer.java Sat Sep 10 07:56:38 2016
@@ -28,7 +28,6 @@ import org.apache.jmeter.util.JMeterUtil
*
* @since 3.0
*/
-// TODO Add support of "TOTAL" statistics line
public class StatisticsSummaryConsumer extends
AbstractSummaryConsumer<StatisticsSummaryData> {
@@ -84,7 +83,7 @@ public class StatisticsSummaryConsumer e
overallData = new StatisticsSummaryData(PERCENTILE_INDEX1,
PERCENTILE_INDEX2, PERCENTILE_INDEX3);
overallInfo.setData(overallData);
- }
+ }
StatisticsSummaryData data = info.getData();
if (data == null) {
@@ -93,8 +92,10 @@ public class StatisticsSummaryConsumer e
info.setData(data);
}
- aggregateSample(sample, data);
- aggregateSample(sample, overallData);
+ if(!sample.isEmptyController()) {
+ aggregateSample(sample, data);
+ aggregateSample(sample, overallData);
+ }
}
/*