You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "hiroyuki-sato (via GitHub)" <gi...@apache.org> on 2026/07/23 00:42:25 UTC
[PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
hiroyuki-sato opened a new pull request, #50610:
URL: https://github.com/apache/arrow/pull/50610
### Rationale for this change
This is the sub issue #44748.
* SC2027: The surrounding quotes actually unquote this. Remove or escape them.
* SC2086: Double quote to prevent globbing and word splitting.
* SC2223: This default assignment may cause DoS due to globbing. Quote it.
```
shellcheck ci/scripts/r_deps.sh
In ci/scripts/r_deps.sh line 21:
: ${R_BIN:=R}
^---------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
In ci/scripts/r_deps.sh line 23:
: ${R_PRUNE_DEPS:=FALSE}
^--------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
In ci/scripts/r_deps.sh line 24:
R_PRUNE_DEPS=`echo $R_PRUNE_DEPS | tr '[:upper:]' '[:lower:]'`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
R_PRUNE_DEPS=$(echo "$R_PRUNE_DEPS" | tr '[:upper:]' '[:lower:]')
In ci/scripts/r_deps.sh line 26:
: ${R_DUCKDB_DEV:=FALSE}
^--------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
In ci/scripts/r_deps.sh line 27:
R_DUCKDB_DEV=`echo $R_DUCKDB_DEV | tr '[:upper:]' '[:lower:]'`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
R_DUCKDB_DEV=$(echo "$R_DUCKDB_DEV" | tr '[:upper:]' '[:lower:]')
In ci/scripts/r_deps.sh line 31:
pushd ${source_dir}
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
pushd "${source_dir}"
In ci/scripts/r_deps.sh line 33:
if [ ${R_PRUNE_DEPS} = "true" ]; then
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "${R_PRUNE_DEPS}" = "true" ]; then
In ci/scripts/r_deps.sh line 46:
${R_BIN} -e "options(warn=2); install.packages('remotes'); remotes::install_cran(c('glue', 'rcmdcheck', 'sys')); remotes::install_deps(INSTALL_opts = '"${INSTALL_ARGS}"')"
^-------------^ SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
${R_BIN} -e "options(warn=2); install.packages('remotes'); remotes::install_cran(c('glue', 'rcmdcheck', 'sys')); remotes::install_deps(INSTALL_opts = '""${INSTALL_ARGS}""')"
In ci/scripts/r_deps.sh line 49:
if [ ${R_DUCKDB_DEV} == "true" ]; then
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "${R_DUCKDB_DEV}" == "true" ]; then
In ci/scripts/r_deps.sh line 55:
${R_BIN} -e "remotes::install_deps(dependencies = TRUE, INSTALL_opts = '"${INSTALL_ARGS}"')"
^-------------^ SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.
^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
${R_BIN} -e "remotes::install_deps(dependencies = TRUE, INSTALL_opts = '""${INSTALL_ARGS}""')"
For more information:
https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
https://www.shellcheck.net/wiki/SC2223 -- This default assignment may cause...
```
### What changes are included in this PR?
* SC2027: Remove redundant quotes.
* SC2086: Quote variable expansions.
* SC2223: Quote default variable assignments.
### Are these changes tested?
### Are there any user-facing changes?
**This PR includes breaking changes to public APIs.** (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
**This PR contains a "Critical Fix".** (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5114905754
Rebased after #50671 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5138845401
Revision: b98fafc194b3130129b4d0c4d40b60ea1fabe5a5
Submitted crossbow builds: [ursacomputing/crossbow @ actions-55c8e3be77](https://github.com/ursacomputing/crossbow/branches/all?query=actions-55c8e3be77)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/30600965153/job/91063421207)|
|r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/30600965885/job/91063322433)|
|test-r-alpine-linux-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/30600965376/job/91063320674)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/30600964260/job/91063317249)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/30600965573/job/91063321313)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/30600964514/job/91063317885)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/30600964412/job/91063317347)|
|test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/30600963882/job/91063315820)|
|test-r-fedora-clang|[](https://github.com/ursacomputing/crossbow/actions/runs/30600964310/job/91063317063)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/30600964535/job/91063318130)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/30600964351/job/91063317212)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/30600965424/job/91063320842)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/30600964054/job/91063316417)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/30600964932/job/91063319244)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/30600964138/job/91063316575)|
|test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/30600965190/job/91063320072)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/30600965010/job/91063319561)|
|test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/30600964259/job/91063316924)|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/30600964956/job/91063319662)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/30600963962/job/91063316083)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/30600964733/job/91063318583)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/30600965275/job/91063320475)|
|test-r-wasm|[](https://github.com/ursacomputing/crossbow/actions/runs/30600965761/job/91063321855)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5069951555
Revision: fab7f572cc5f39f81536ab7210cc881cbb6afbe4
Submitted crossbow builds: [ursacomputing/crossbow @ actions-bc2d28fb9f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-bc2d28fb9f)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/30093889951/job/89483226900)|
|r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/30093889635/job/89483227442)|
|test-r-alpine-linux-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/30093887280/job/89483219035)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/30093888423/job/89483222373)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/30093886524/job/89483216582)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/30093889180/job/89483224786)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/30093888033/job/89483221243)|
|test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/30093886742/job/89483217132)|
|test-r-fedora-clang|[](https://github.com/ursacomputing/crossbow/actions/runs/30093889465/job/89483225494)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/30093888723/job/89483223148)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/30093889368/job/89483225404)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/30093886497/job/89483216572)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/30093888845/job/89483223725)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/30093887539/job/89483219814)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/30093887529/job/89483219837)|
|test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/30093887384/job/89483219546)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/30093887109/job/89483218530)|
|test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/30093888637/job/89483223176)|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/30093886530/job/89483216607)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/30093888259/job/89483221901)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/30093886831/job/89483218050)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/30093886899/job/89483217956)|
|test-r-wasm|[](https://github.com/ursacomputing/crossbow/actions/runs/30093888026/job/89483221173)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5069870936
Since #47404 also modifies `.pre-commit-config.yaml`, there may be a merge conflict if either PR is merged first. If that happens, I'll rebase this PR again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5074766651
Could you rebase again for #50587?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5078961669
Revision: e6fe69a37149d5fc51d232fe6fb990dea7372725
Submitted crossbow builds: [ursacomputing/crossbow @ actions-6a5ff9aa9c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6a5ff9aa9c)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/30162729881/job/89690569237)|
|r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/30162730354/job/89690570141)|
|test-r-alpine-linux-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/30162729283/job/89690567474)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/30162729653/job/89690568327)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/30162730528/job/89690570524)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/30162730553/job/89690570695)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/30162729405/job/89690568008)|
|test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/30162730409/job/89690570279)|
|test-r-fedora-clang|[](https://github.com/ursacomputing/crossbow/actions/runs/30162729315/job/89690567504)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/30162729095/job/89690566984)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/30162730106/job/89690569650)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/30162730024/job/89690569441)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/30162730329/job/89690570125)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/30162729831/job/89690568906)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/30162730085/job/89690569495)|
|test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/30162730230/job/89690569823)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/30162729639/job/89690568313)|
|test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/30162729762/job/89690568713)|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/30162729916/job/89690569225)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/30162729191/job/89690567326)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/30162729385/job/89690567694)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/30162729269/job/89690567554)|
|test-r-wasm|[](https://github.com/ursacomputing/crossbow/actions/runs/30162729482/job/89690567889)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on code in PR #50610:
URL: https://github.com/apache/arrow/pull/50610#discussion_r3645396491
##########
.pre-commit-config.yaml:
##########
Review Comment:
@raulcd
Once I fix the remaining six files in `ci/scripts`, we should be able to remove that part.
* `ci/scripts/r_docker_configure.sh`: SC2006 SC2046 SC2086 SC2223
* `ci/scripts/r_install_system_dependencies.sh`: SC2006 SC2223
* `ci/scripts/r_sanitize.sh`: SC2086 SC2155 SC2223
* `ci/scripts/r_test.sh`: SC1091 SC2086 SC2223
* `ci/scripts/r_valgrind.sh`: SC2046 SC2086 SC2223
* `ci/scripts/r_windows_build.sh`: SC2011 SC2034 SC2035 SC2046 SC2086 SC2155 SC2223
We’re almost there 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5166262998
> r-recheck-most was the only check that failed.
>
> I’m not sure what r-recheck-most is, but it looks like other PRs are also failing. For example:
> https://github.com/apache/arrow/pull/50633#issuecomment-5077743433
FTR, these our the R package's reverse dependencies. We have one failure there because a change we released in 25 inadvertently caught something in the `EZbakR` package. We've already upstreamed a fix, and they should be releasing that soon: https://github.com/isaacvock/EZbakR/pull/32
So, TL;DR yes, that failure is something we can ignore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "tadeja (via GitHub)" <gi...@apache.org>.
tadeja commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5128239903
> I’m not sure whether this is related, but I’ll rebase this PR after #50651 is merged just in case.
@hiroyuki-sato #50705 was merged instead of #50651, `test-r-macos-as-cran` should pass after rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #50610:
URL: https://github.com/apache/arrow/pull/50610#discussion_r3635184396
##########
ci/scripts/r_deps.sh:
##########
@@ -43,15 +43,15 @@ fi
# install.packages() emits warnings if packages fail to install,
# but we want to error/fail the build.
# options(warn=2) turns warnings into errors
-${R_BIN} -e "options(warn=2); install.packages('remotes'); remotes::install_cran(c('glue', 'rcmdcheck', 'sys')); remotes::install_deps(INSTALL_opts = '"${INSTALL_ARGS}"')"
+"${R_BIN}" -e "options(warn=2); install.packages('remotes'); remotes::install_cran(c('glue', 'rcmdcheck', 'sys')); remotes::install_deps(INSTALL_opts = '""${INSTALL_ARGS}""')"
Review Comment:
Does this work?
```suggestion
"${R_BIN}" -e "options(warn=2); install.packages('remotes'); remotes::install_cran(c('glue', 'rcmdcheck', 'sys')); remotes::install_deps(INSTALL_opts = '\"${INSTALL_ARGS}\"')"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #50610:
URL: https://github.com/apache/arrow/pull/50610#discussion_r3645352284
##########
.pre-commit-config.yaml:
##########
Review Comment:
from my understanding we are close to having this. Is the idea to have a follow up and remove this list afterwards. I am unsure if there has been new shell scripts created since this list was built.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5087571619
I’m not sure whether this is related, but I’ll rebase this PR after #50651 is merged just in case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5163478108
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a947bc432cb7fe42f2e8007a37ec11d3dfeea03d.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/91621998188) has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5075607129
Revision: 11523fd0233b711876005735d3eb598ef9ce45be
Submitted crossbow builds: [ursacomputing/crossbow @ actions-b355b52d7d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-b355b52d7d)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/30134400824/job/89615374041)|
|r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/30134399320/job/89615273348)|
|test-r-alpine-linux-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/30134399355/job/89615273403)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/30134399142/job/89615272646)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/30134398637/job/89615271146)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/30134399602/job/89615274167)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/30134400114/job/89615276065)|
|test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/30134399298/job/89615273222)|
|test-r-fedora-clang|[](https://github.com/ursacomputing/crossbow/actions/runs/30134399321/job/89615273289)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/30134400033/job/89615275620)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/30134399473/job/89615273847)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/30134398668/job/89615271338)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/30134398736/job/89615271489)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/30134400227/job/89615276325)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/30134399825/job/89615275021)|
|test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/30134400050/job/89615275780)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/30134399253/job/89615273035)|
|test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/30134398461/job/89615270826)|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/30134399216/job/89615272774)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/30134398370/job/89615270480)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/30134399837/job/89615275056)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/30134398922/job/89615272114)|
|test-r-wasm|[](https://github.com/ursacomputing/crossbow/actions/runs/30134399250/job/89615273028)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5075592013
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5078464449
I’ll rebase after #50636 is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5071960885
Error is unrelated, is a flaky timeout with minio:
```
> raise TimeoutExpired(self.args, timeout)
E subprocess.TimeoutExpired: Command '['mc', '-C', '/private/var/folders/8j/3c4g2vh16vgc8j40cj25qfqh0000gn/T/pytest-of-runner/pytest-0/popen-gw0/mc', 'admin', 'policy', 'attach', 'myminio/', 'no-create-buckets', '--user', 'test_dataset_limited_user']' timed out after 10 seconds
/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/subprocess.py:2045: TimeoutExpired
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5055287131
Revision: 85f2b3ee56539e6ed2a8b8b286207a1fd67667df
Submitted crossbow builds: [ursacomputing/crossbow @ actions-47fe7ddf85](https://github.com/ursacomputing/crossbow/branches/all?query=actions-47fe7ddf85)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/29985771772/job/89137236531)|
|r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/29985773363/job/89137130377)|
|test-r-alpine-linux-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/29985771144/job/89137124044)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/29985770907/job/89137123398)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/29985771376/job/89137124939)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/29985771449/job/89137125206)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/29985772532/job/89137128222)|
|test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/29985770393/job/89137121814)|
|test-r-fedora-clang|[](https://github.com/ursacomputing/crossbow/actions/runs/29985770910/job/89137123395)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/29985772599/job/89137128194)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/29985772099/job/89137126873)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/29985772122/job/89137127053)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/29985770936/job/89137123409)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/29985771222/job/89137124494)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/29985772167/job/89137127016)|
|test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/29985772713/job/89137128610)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/29985770616/job/89137122514)|
|test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/29985771294/job/89137124744)|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/29985770722/job/89137122822)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/29985772315/job/89137127387)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/29985771982/job/89137126479)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/29985771606/job/89137125697)|
|test-r-wasm|[](https://github.com/ursacomputing/crossbow/actions/runs/29985771347/job/89137124860)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5075594794
@kou @raulcd Thank you for your comment. rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5078948877
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5053090520
:warning: GitHub issue #50609 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5053686262
Revision: 48a4a038bcee3cdee15bc55bbb41a0eab5fc4a83
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a93615c8b7](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a93615c8b7)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/29974688819/job/89103956612)|
|r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/29974688104/job/89103863833)|
|test-r-alpine-linux-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/29974688741/job/89103865598)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/29974689056/job/89103866441)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/29974687885/job/89103863028)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/29974688420/job/89103864678)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/29974688705/job/89103865438)|
|test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/29974688252/job/89103864237)|
|test-r-fedora-clang|[](https://github.com/ursacomputing/crossbow/actions/runs/29974687363/job/89103861521)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/29974687530/job/89103862024)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/29974688047/job/89103863446)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/29974687545/job/89103862126)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/29974687295/job/89103861334)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/29974688061/job/89103863809)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/29974688860/job/89103865897)|
|test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/29974687758/job/89103862672)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/29974687959/job/89103863148)|
|test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/29974688753/job/89103865581)|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/29974687662/job/89103862401)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/29974687338/job/89103861467)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/29974688917/job/89103866009)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/29974688375/job/89103864663)|
|test-r-wasm|[](https://github.com/ursacomputing/crossbow/actions/runs/29974688791/job/89103865622)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5144313121
`r-recheck-most` was the only check that failed.
I’m not sure what r-recheck-most is, but it looks like other PRs are also failing. For example:
https://github.com/apache/arrow/pull/50633#issuecomment-5077743433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5053668133
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on code in PR #50610:
URL: https://github.com/apache/arrow/pull/50610#discussion_r3636083755
##########
ci/scripts/r_deps.sh:
##########
@@ -43,15 +43,15 @@ fi
# install.packages() emits warnings if packages fail to install,
# but we want to error/fail the build.
# options(warn=2) turns warnings into errors
-${R_BIN} -e "options(warn=2); install.packages('remotes'); remotes::install_cran(c('glue', 'rcmdcheck', 'sys')); remotes::install_deps(INSTALL_opts = '"${INSTALL_ARGS}"')"
+"${R_BIN}" -e "options(warn=2); install.packages('remotes'); remotes::install_cran(c('glue', 'rcmdcheck', 'sys')); remotes::install_deps(INSTALL_opts = '""${INSTALL_ARGS}""')"
Review Comment:
Thank you for your comment.
I tried your suggested change, but the CI failed.
https://github.com/apache/arrow/actions/runs/29978332833
As I understand it, the original expression is split into three parts. In this case, I think they can be combined into a single string without the extra double quotes.
`"remotes::install_deps(dependencies = TRUE, INSTALL_opts = '"${INSTALL_ARGS}"')"`
* `"remotes::install_deps(dependencies = TRUE, INSTALL_opts = '"`
* `${INSTALL_ARGS}`
* `"')"`
After removing the double quotes, the CI passed. What do you think of this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5055263231
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5065515388
Let's wait for #50587 before we merge this because the current R related CI jobs are broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5067778474
Thanks I got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5138825885
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5078947168
rebase after #50633 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5138824005
@tadeja Thank you for your comment. Rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #50610:
URL: https://github.com/apache/arrow/pull/50610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #50610:
URL: https://github.com/apache/arrow/pull/50610#discussion_r3642543839
##########
ci/scripts/r_deps.sh:
##########
@@ -43,15 +43,15 @@ fi
# install.packages() emits warnings if packages fail to install,
# but we want to error/fail the build.
# options(warn=2) turns warnings into errors
-${R_BIN} -e "options(warn=2); install.packages('remotes'); remotes::install_cran(c('glue', 'rcmdcheck', 'sys')); remotes::install_deps(INSTALL_opts = '"${INSTALL_ARGS}"')"
+"${R_BIN}" -e "options(warn=2); install.packages('remotes'); remotes::install_cran(c('glue', 'rcmdcheck', 'sys')); remotes::install_deps(INSTALL_opts = '""${INSTALL_ARGS}""')"
Review Comment:
OK. Let's use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5070741039
Is the failure of the "Python / AMD64 macOS 15-intel Python 3 (pull_request)" CI job related to this PR?
https://github.com/apache/arrow/actions/runs/30093588302/job/89482235673?pr=50610#step:11:563
```
SKIPPED [1] ../../../../../Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/pyarrow/tests/test_fs.py:835: Command ['azurite-blob', '--location', local('/private/var/folders/8j/3c4g2vh16vgc8j40cj25qfqh0000gn/T/pytest-of-runner/pytest-0/popen-gw3'), '--blobPort', '49614', '--skipApiVersionCheck'] failed to execute: [Errno 2] No such file or directory: 'azurite-blob'
```
It passed before the rebase, so I suspect the failure may be unrelated to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5069908003
#47404 has been merged, so I rebased this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50609: [CI][Dev] Fix shellcheck errors in the ci/scripts/r_deps.sh [arrow]
Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50610:
URL: https://github.com/apache/arrow/pull/50610#issuecomment-5069924542
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org