[jira] Commented: (FELIX-2313) fileinstall does not recognize jars if it does not have Bundle-SymbolicName and Bundle-Version

["Guillaume Nodet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-2313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862720#action_12862720 ] 

Guillaume Nodet commented on FELIX-2313:
----------------------------------------

Not sure what that would mean to install a jar which is not an osgi bundle.
This must have changed in version 2.0.0.
>From this version, you have custom installers if you want to install artifacts that are not osgi bundles, such as wars, blueprint configuration files, etc...
If we were to bypass the check and install all jars, that would remove this feature.

>From OSGI r4, an osgi bundle must have at least the following manifest entries:  Bundle-ManifestVersion and Bundle-SymbolicName.  Supporting OSGi r3 bundles is not mandatory for a given framework.  See section 3.5 of the OSGi core spec.

> fileinstall does not recognize jars if it does not have Bundle-SymbolicName and Bundle-Version
> ----------------------------------------------------------------------------------------------
>
>                 Key: FELIX-2313
>                 URL: https://issues.apache.org/jira/browse/FELIX-2313
>             Project: Felix
>          Issue Type: Bug
>          Components: File Install
>    Affects Versions: karaf-1.4.0
>            Reporter: Sahoo
>
> FileInstall does not recognize jar files that have only Bundle-SymbolicName. I see the following code in BundleTransformer.java:
>            if (m.getMainAttributes().getValue(new Attributes.Name("Bundle-SymbolicName")) != null
>                && m.getMainAttributes().getValue(new Attributes.Name("Bundle-Version")) != null)
>  Why is this the case? Earlier fileinstall used to be able install anything that's a jar file.
> Questions: Why does FileInstall care about existence of any kind of manifest entries? Is not every jar file technically an OSGi bundle? So, it should be sufficient to just have the following check:
> try {
>    new JarFile(artifact).close();
> } catch(Exception e){
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.