[GitHub] [madlib] orhankislal commented on a change in pull request #462: DL: Add asymmetric cluster support for fit and evaluate

[GitBox <gi...@apache.org>]

orhankislal commented on a change in pull request #462: DL: Add asymmetric cluster support for fit and evaluate
URL: https://github.com/apache/madlib/pull/462#discussion_r353360885
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras_wrapper.py_in
 ##########
 @@ -56,7 +57,7 @@ def reset_cuda_env(value):
     else:
         del os.environ[CUDA_VISIBLE_DEVICES_KEY]
 
-def get_device_name_and_set_cuda_env(gpus_per_host, seg):
+def get_device_name_and_set_cuda_env_predict(gpus_per_host, seg):
 
 Review comment:
   This PR doesn't update predict. I am working on a separate PR for it. This function is renamed to keep predict intact while we change fit/evaluate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services