You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/01/23 09:51:56 UTC

[GitHub] tillrohrmann opened a new pull request #7564: [FLINK-11415] Introduce JobMasterServiceFactory

tillrohrmann opened a new pull request #7564: [FLINK-11415] Introduce JobMasterServiceFactory
URL: https://github.com/apache/flink/pull/7564
 
 
   ## What is the purpose of the change
   
   The JobMasterServiceFactory controls how the JobMasterService is constructed by
   the JobManagerRunner. This allows for an easier testing of this component.
   
   This PR is based on #7563.
   
   ## Brief change log
   
   - Introduce `JobMasterServiceFactory`
   - Replace direct instantiation of the `JobMaster` in `JobManagerRunner` with factory
   - Move instantiation code into `DefaultJobMasterServiceFactory`
   
   ## Verifying this change
   
   - Covered by existing tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services